[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1007025: git-multimail 1.6.0 package review



Hi,
On Thu, Sep 22, 2022 at 02:12:07PM -0400, Antoine Beaupré wrote:
On 2022-09-22 19:43:24, Jeroen Ploemen wrote:
On Thu, 22 Sep 2022 12:35:12 -0400
Antoine Beaupré <anarcat@debian.org> wrote:

I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:

override_dh_auto_install:
        dh_auto_install
        mv debian/git-multimail/usr/bin/git_multimail.py
debian/git-multimail/usr/bin/git-multimail

Antoine, IIRC the git_multimail.py file upstream installs into
/usr/bin is not a launcher but a full copy of the module as installed
into /usr/lib/python3. The code in that file auto-detects whether
it's run as a program.

Oh. I misunderstood that, sorry.

Sorry, maybe my words misled you also here.


That resulted in two copies of that sizeable file in the package I
reviewed back in June. Hence my suggestion - quoted in an earlier
message by Bo - to replace the copy in /usr/bin with a tiny launcher,
reducing the installed size of the package by almost half.

Sure, that completely makes sense then, sorry.

Ok, I have re-enabled the launcher and other issues fixed for git-multimail
as your and jcfp's suggestions.

Thanks all and please let me know if any issues.

--
Regards,
--
  Bo YU

Attachment: signature.asc
Description: PGP signature


Reply to: