Re: git-multimail 1.6.0 package review

[Antoine Beaupré <anarcat@debian.org>]

On 2022-09-15 17:32:33, Antoine Beaupré wrote:
> Hi!
>
> I've done a quick review of the 1.6.0 package on salsa as of commit
> d5bd184a1cf73b752f80dea46d8080493a5e663b.

[...]

> Also, I didn't quite follow the work on the test cases, but why did you
> replace pep8 by pycodestyle in the patch in debian/patches? The patch
> itself doesn't actually explain the *why* (it explains the "what" but we
> typically want more than this...)

I have just found you have reported this upstream in:

https://github.com/git-multimail/git-multimail/issues/221

... which is great! Could you also open a PR against the repository and
link that in the patch?

You might want to review the patch tagging guidelines as well, as this
is the kind of things it answers:

https://dep-team.pages.debian.net/deps/dep3/

Finally, one fundamental issue with this package is that, as you
correctly identified, it's unmaintained upstream. If we do ship it in
Debian, maybe we'd want to keep it out of stable until that is settled?

a.
-- 
I've got to design so you can put it together out of garbage cans. In
part because that's what I started from, but mostly because I don’t
trust the industrial structure—they might decide to suppress us
weirdos and try to deny us the parts we need.
                       - Lee Felsenstein