Review of python-bonsai
Hi!
Here's my review of python-bonsai:
1. d/control:
* You don't need the "(>= 3.6)" restriction for python3-all-dev, as that
version isn't even in oldstable.
* sphinx-common isn't needed for the source package, as python3-sphinx
depends on it
* "python3 (>= 3.6)" is not required for python3-bonsai,
${python3:Depends} should take care of that for you.
* IMO, python3-bonsai should recommend or suggest python3-bonsai-doc,
but that's up to you.
---------
2. d/copyright:
* you forgot to add a debian/* section. AFAIU, noirello isn't the one
who wrote d/rules :)
* .appveyor/run_with_env.cmd is licensed CC0. You probably don't need
those files, so you can exclude them from the source package using
Files-Excluded in d/copyright
* the MIT license in Debian is named "Expat", for historical reasons.
---------
4. d/rules:
* You left "export DH_VERBOSE = 1" uncommented.
* I'm curious to why you need to set "export LC_ALL = C.UTF-8".
---------
5. d/tests:
I don't have an autopkgtests setup that has machine-level isolation. You
ran that code and it works?
---------
6. d/watch:
You left "<project>" in there instead of replacing it by the actual
project's name (have a look at Lintian) :) Note you can use the "git
tag" mode to simplify this file (not that it's required, your file works
as-is): [1]
---------
7. Upstream code
Have you read the upstream code? It's something you should do (and you
should read all the changes for each new update). Not that you have to
do a proper security audit, but you should go through the code to be
sure there's no obvious or dangerous things in there.
Otherwise, good job! Fix those, ping me and if it's OK, I'll read the
upstream code myself and sponsor it.
Cheers,
[1]:
https://salsa.debian.org/python-team/packages/python-mediafile/-/blob/debian/master/debian/watch
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
⠈⠳⣄
Reply to: