[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: sphinxext-opengraph build with tests.



Hello Chiara,

> I have committed to salsa a new version of sphinxext-opengraph running tests at the build time.
> There are no updates on upstream.
>
> It's not urgent, but if someone want to check my solution (as this is my first using autopkgtest)...

i dont think that's how you should run autopkgtests: they are supposed
to run against the installed package (the way you set them up is
essentially equivalent to how they run during build).

For an example of what that means, you can have a look at (shameless
plug): https://salsa.debian.org/python-team/packages/httpx/-/tree/debian/master/debian/tests

> Also, Sandro do you mind letting me know if this is worth a new package version 0.5.0-2? I will update changelog accordingly if needed.

it is my opinion that every time you make a change to a package, you
should also add a relevant entry in debian/changelog, describing what
the change is, and the updated d/changelog should be included in the
same commit introducing the change (as oppose to write
debian/changelog all at once before an upload). With that said, yes a
-2 would be nice, and once autopkgtest is fixed i think it would
appropriate to upload the package, without waiting for a new upstream
release.

Regards,
-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi


Reply to: