Taking over DPMT (Was: python-boto: autopkgtest failure with Python 3.8 as default)
Hi Emmanuel,
thanks a lot for your patch. Please note that you crafted it against
GIt which is lagging behind the latest NMU. I intended to apply it
anyway - but it does not solve
======================================================================
ERROR: test_constructor (tests.unit.utils.test_utils.TestPassword)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.Trbllh/autopkgtest_tmp/tests/unit/utils/test_utils.py", line 104, in test_constructor
password.set('foo')
File "/usr/lib/python3/dist-packages/boto/utils.py", line 787, in set
self.str = self.hashfunc(value).hexdigest()
File "/tmp/autopkgtest.Trbllh/autopkgtest_tmp/tests/unit/utils/test_utils.py", line 101, in <lambda>
hmac_hashfunc = lambda msg: hmac.new(b'mysecretkey', msg)
File "/usr/lib/python3.8/hmac.py", line 153, in new
return HMAC(key, msg, digestmod)
File "/usr/lib/python3.8/hmac.py", line 51, in __init__
raise TypeError("Missing required parameter 'digestmod'.")
TypeError: Missing required parameter 'digestmod'.
======================================================================
ERROR: test_hmac (tests.unit.utils.test_utils.TestPassword)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.Trbllh/autopkgtest_tmp/tests/unit/utils/test_utils.py", line 93, in test_hmac
self.clstest(HMACPassword)
File "/tmp/autopkgtest.Trbllh/autopkgtest_tmp/tests/unit/utils/test_utils.py", line 61, in clstest
self.assertNotEquals(password, 'foo')
File "/usr/lib/python3.8/unittest/case.py", line 1410, in deprecated_func
return original_func(*args, **kwargs)
File "/usr/lib/python3.8/unittest/case.py", line 918, in assertNotEqual
if not first != second:
File "/usr/lib/python3/dist-packages/boto/utils.py", line 797, in __eq__
return str(self.hashfunc(other).hexdigest()) == str(self.str)
File "/tmp/autopkgtest.Trbllh/autopkgtest_tmp/tests/unit/utils/test_utils.py", line 88, in hmac_hashfunc
return hmac.new(b'mysecretkey', msg)
File "/usr/lib/python3.8/hmac.py", line 153, in new
return HMAC(key, msg, digestmod)
File "/usr/lib/python3.8/hmac.py", line 51, in __init__
raise TypeError("Missing required parameter 'digestmod'.")
TypeError: Missing required parameter 'digestmod'.
----------------------------------------------------------------------
Ran 1730 tests in 5.640s
FAILED (SKIP=6, errors=3)
On Tue, Mar 24, 2020 at 11:10:28AM -0300, eamanu wrote:
> I prepare a non-maintainer upload patch that I attach.
>
> Please consider apply it.
>
> Also I make a MR [0]
>
> [0] https://salsa.debian.org/eevans/python-boto/-/merge_requests/1
I wonder whether we should take over python-boto into DPMT maintenance
which would enable commits to Git way more easily.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: