On 2020-10-06 12 h 07, Louis-Philippe Véronneau wrote:
> On 2020-10-03 15 h 35, Sandro Tosi wrote:
>> attached the dd-list of the packages missing the pristine-tar branch (some
>> may have been moved/removed, but these are actual repos in DPT)
>>
>> On Fri, Jul 10, 2020 at 12:38 AM Sandro Tosi <morph@debian.org> wrote:
>>
>>> Hello,
>>> i would like to propose a project to make sure our teams (DPMT/PAPT)
>>> repos are using pristine-tar properly.
>>>
>>> The checks i have in mind for now, are:
>>>
>>> * pristine-tar branch must exist, if not -> it's a bug
>>> * pristine-tar + upstream branch must produce the same tarball as
>>> downloaded from the archive, if not -> it's a bug
>>> * bonus point: fix the repo if it doesn't generate the right tarball
>>> and or the branch is missing.
>>> * bonus point: make this into a service that runs regularly (not
>>> strictly necessary to be limited to us)
>>>
>>> i guess we should have a brief discussion about additional checks
>>> and/or procedures before "assigning" it to a volunteer. let's say up
>>> to 2 weeks of discussion, and during the same period volunteers can
>>> nominate themselves.
>>>
>>> I marked this project as newcomers as it doesn't require to be a DD/DM
>>> to work on it, you just need a salsa account and access to our teams.
>>> a handy tool to retrieve all our repos is at
>>>
>>> https://salsa.debian.org/python-team/tools/python-modules
>>> https://salsa.debian.org/python-team/tools/python-apps
>>>
>>> that contains a config file for `mr` and a `checkout` script to fetch
>>> the repos registered in that config file.
>>>
>>> Please feel free to discuss this project now :)
>
> I had a chat with folks in #debian-qa last night, as I agree such checks
> would be nice to have.
>
> 1. Lintian is not suited for that kind of checks, as it does not have
> network access. Frankensteining lintian to do that kind of stuff would
> surely be met with fierce opposition.
>
> 2. The vcswatch script [1] from the QA team already does something akin
> to what we would want. It's written in Perl [2], but doesn't look
> terribly complicated. When a check doesn't pass, it issues an
> action-item like this one [3].
>
> I think the first step would be modifying vcswatcher to issue warnings for:
>
> * the absence of pristine-tar branches
> * missing git tags
> * repositories using 'master' instead of 'debian/master' as the main branch
>
> Once these are flagged, we can easily script a way to fix them, maybe
> even using lintian-brush?
I meant Debian Janitor here.
I don't know the codebase enough, but in my mind, having the thing that
fixes problems and the thing that flags them be separate is valuable. I
don't know if Janitor follows that philosophy though.
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
⠈⠳⣄