Re: RFS: opentracing-python/2.2.0-1 [ITP] -- opentracing interface for Python
On 11/20/19 10:53 PM, Fabrice BAUZAC-STEHLY wrote:
> Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/o/opentracing-python/opentracing-python_2.2.0-1.dsc
Hi,
My review.
d/changelog:
============
No need to write "[ Fabrice BAUZAC ]". That's for when there's multiple
persons in the changelog.
d/compat:
=========
Please get rid of this file, and in d/control write debhelper-compat
(=12) instead (and remove debhelper there).
d/control:
==========
Not mandatory, but it'd be nice to run "wrap-and-sort -bastk" to
clean-up build-depends ordering.
d/copyright:
============
There's no "Files: *" entry there, and it looks like you're listing all
the files of upstream. Please don't do that.
The only blocker I see is about d/copyright, the other things are more
cosmetic changes that I'm suggesting.
Cheers,
Thomas Goirand (zigo)
Reply to: