Re: How to disable tests for Python2 only?
- To: Andrey Rahmatullin <wrar@debian.org>
- Cc: Andreas Tille <andreas@an3as.eu>, 907806@bugs.debian.org, debian-python@lists.debian.org, Debian Science List <debian-science@lists.debian.org>, Mo Zhou <cdluminate@gmail.com>
- Subject: Re: How to disable tests for Python2 only?
- From: Yaroslav Halchenko <yoh@debian.org>
- Date: Mon, 10 Sep 2018 10:54:02 -0400
- Message-id: <[🔎] 20180910145402.GE3707@hopa.kiewit.dartmouth.edu>
- Mail-followup-to: Andrey Rahmatullin <wrar@debian.org>, Andreas Tille <andreas@an3as.eu>, 907806@bugs.debian.org, debian-python@lists.debian.org, Debian Science List <debian-science@lists.debian.org>, Mo Zhou <cdluminate@gmail.com>
- In-reply-to: <[🔎] 20180910144706.GF1624@belkar.wrar.name>
- References: <[🔎] 20180910143321.bx6icicf5bwsbz4r@an3as.eu> <[🔎] 20180910144706.GF1624@belkar.wrar.name>
On Mon, 10 Sep 2018, Andrey Rahmatullin wrote:
> On Mon, Sep 10, 2018 at 04:33:21PM +0200, Andreas Tille wrote:
> > Hi,
> > looking at the bug log of scikit-learn[1] it seems to be a simple means to do
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -20,6 +20,7 @@ Build-Depends: debhelper (>= 9), dh-autoreconf,
> > python3-pytest,
> > python3-matplotlib,
> > python3-joblib (>= 0.9.2),
> > + python3-distributed <!nocheck>,
> > libsvm-dev (>= 2.84.0),
> > libatlas3-base,
> > Build-Depends-Indep:
> I don't think that's how build profiles work.
> > However, it seems that due to the fact that this package uses
> > --buildsystem=python_distutils
> Which is already a problem, as it doesn't support py3.
> There is a lot of strange hacks in this rules file. I'm especially
> interested in "dh_autoreconf debian/rules -- clean_generated" but that's a
> question for another discussion.
many hacks might be left overs for historical (age of the package)
+ backports (hence cythonize rule, allows to provide backports for older
debian/ubuntu via neurodebian) reason. Would be nice to review/remove
those no longer needed, but attention should be taken care not to break
backportability. So far built/tested fine even for jessie (8) and ubuntu
xenial (16.04).
> > Are there any other ways to exclude some tests for Python2 to make this
> > package build again?
> rules call nosetests directly so I guess find out how to do that with
> nosetests.
overall, as I've just noted in the bugreport, I think it is better to
concentrate on making upcoming 0.20 (will use pytest not nose among
other things) into debian.
Outstanding few issues so far are reported/dealt with upstream:
https://github.com/scikit-learn/scikit-learn/issues?q=is%3Aopen+is%3Aissue+author%3Ayarikoptic+label%3ABlocker
updating packaging is in debian-0.20 branch at
http://github.com/yarikoptic/scikit-learn
--
Yaroslav O. Halchenko
Center for Open Neuroscience http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik
Reply to: