[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#900368: RFS: pygithub/1.40a3-1 [ITP]



Control: merge 898416 898811 900368

Hi Emmanuel!

On Tue, May 29, 2018 at 12:35:25PM -0300, eamanu15 wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "pygithub"

Note that I am merging your three RFS bugs. If you want to ping, just reply
to the existing bug, not file a new one.

Here are my comments about your changes.

- It would be nice if you based the repository on the existing Git
  repository [1], rather than starting from scratch.

  Also for new team repositories as this one, it is better to use Gbp-Pq
  workflow as described in the team wiki [2].

- Please merge the last three changelog entries, as 1.35-1 upload did not
  happen.

- When building in the current sid, I get Lintian warnings about three files
  shipped in /usr/lib/python3.7/dist-packages/.

  That probably happens because of output of 2to3 is slightly different in
  Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and
  dh_python3 does not remove the file if it does not match.

  I would recommend removing debian/python3-github/usr/lib/python3.* manually
  in debian/rules. Keeping debian-python@ in Cc in case someone has a better
  idea.

- A new stable 1.40 release has been released on June 26th [3].
  Can you update from alpha to the stable version?

  Also please add uversionmangle to debian/watch (like here [4]), to make it
  treat 1.40 as a higher version than 1.40aN.

[1]: https://alioth-archive.debian.org/git/users/kaction-guest/pygithub.git.tar.xz
[2]: https://wiki.debian.org/Python/GitPackagingPQ
[3]: https://pypi.org/project/PyGithub/1.40/
[4]: https://pypi.debian.net/PyGithub/watch

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature


Reply to: