Hi Paolo,
<fill here my recommendations about RFS bugs..>
On Tue, Nov 29, 2016 at 08:33:20AM +0100, Paolo Greppi wrote:
> I packaged python-jsonref as per this ITP:
> https://bugs.debian.org/844986, this is the repo:
> https://anonscm.debian.org/cgit/python-modules/packages/python-jsonref.git
>
> Please someone more experienced than me review it and if it's OK sponsor
> its upload.
* git is lacking a pristine-tar branch, please push it (I don't even try
to build without)
* d/control:
+ please wrap-and-sort that list of build-deps
+ maintainer is you, and DPMT is nowhere to be seen
+ why is Testsuite commented out?
* please bump compat to 10
* d/rules:
+ I think you need to also do --with sphinx to have dh_sphnixdocs do
it's job?
* d/copyright:
+ why are you listing all the files instead of using wildcards?!
+ is there a particular reason the license of debian/ is different and
more stricter than upstream's?
+ no need to repeat "Copyright (C)" on the Copyright: lines
+ also I very much like emails in d/copright
+ the license field of upstream also include the copyright notice, it
shouldn't
* that proxytypes.py has a "based on the implementation..", are you sure
that's not under a different copyright/license? (if so upstream might
be at fault here, and this package might not be redistributable)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature