On Fri, Aug 19, 2016 at 10:47:37PM +0200, Elena ``of Valhalla'' wrote:
> On 2016-08-18 at 22:27:42 +0000, Mattia Rizzolo wrote:
> > * Files-Excluded in d/copyright doesn't list all the files that are
> > removed (at least according to `git diff --stat
> > upstream/0.9..upstream/0.9+ds0`)
> > besides, wrapping that list might not be a bad idea
>
> Uhm, I used uscan to remove the files, so nothing that wasn't listed was
> removed.
>
> Do you mean that I should explicitely list all of the content of the
> directory ``codicefiscale.egg-info``, instead of just listing the
> directory?
No, it just means that I rashed too much at reviewing it last night and
was already sleeping.
I didn't notice all those files where inside a directory -.-'
> > * why do you disable the tests? (a comment on d/rules might not be a
> > bad idea here either)
> > + I see setup.py lists non-existant tests, if that's the issue maybe
> > you can get that tests= arg removed (or the actual tests included)
> > upstream?
>
> That's exactly the issue, I've added a comment with a pointer to
> https://github.com/ema/pycodicefiscale/issues/6
The project doesn't strike me as very active, but thanks :)
> > * just quickly skimming over the README, I think it would make sense to
> > include in the binaries, as it provides quick documentation (I think)
>
> yes, it does, you're right (added in git)
You did this:
diff --git a/debian/docs b/debian/docs
new file mode 100644
index 0000000..a1320b1
--- /dev/null
+++ b/debian/docs
@@ -0,0 +1 @@
+README.rst
This is not going to do what you expect, check both the produced
binaries ;)
(`debc` right after having built the package is handy for that, I run
it in a pbuilder hook for example)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature