[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: unwanted python-X-dbg



[Jeremy Sanders, 2016-05-08]
> Thanks Piotr.
> 
> On 05/08/2016 10:28 AM, Piotr Ożarowski wrote:
> >you don't need these ^ two, that's the default
> 
> ok
> 
> >do you have python3-veusz-dbg binary package?
> >
> >dh_python3 will remove non .py/.so files from -dbg's packages
> >dist-packages directory by default, but this looks like dpkg-source not
> >knowing about python3-veusz-dbg to me
> 
> control just defines veusz and veusz-dbg, so I can't see where

PYBUILD_NAME is useless if you don't provide python-, python3 or pypy-
packages.

> python-veusz-dbg coming from. veusz has a Provides for python3-veusz.

my bet is you built it at least once before setting up PYBUILD_DESTDIR
so these filse are leftovers and, if you rm -rf debian/python-veusz-dbg
they will not be regenerated.


> veusz is an executable and python module (called veusz). The executable is
> probably the most important part, hence the naming of veusz, not
> python3-veusz.

/me puts his evil general hat on

if there's one tiny (or even empty) file in dist-packages directory:
IT'S A LIBRARY! (and binary package name should start with "python")

/me takes the hat off

Why don't you install thes files into /usr/lib/veusz/ ?
Both the normal .so and the debug one (PYBUILD_DESTDIR=debian/veusz and
PYBUILD_INSTALL_ARGS=--install-lib=/usr/lib/veusz/) and move debug .so
file later to veuzsz-dbg package

> By the way, my current work in progress is here:
> http://anonscm.debian.org/viewvc/python-apps/packages/veusz/branches/py3/

please don't hardcode pybuild's internal paths, I will change them from
time to time :P

Index: debian/rules
===================================================================
--- debian/rules	(revision 13177)
+++ debian/rules	(working copy)
@@ -8,12 +8,6 @@
 
 export PYBUILD_NAME=veusz
 
-PYVERS = $(shell py3versions -r -v)
-
-# Callable functions to determine the correct PYTHONPATH
-pythonpath = $$(ls -d $(CURDIR)/.pybuild/pythonX.Y_$(1)/build)
-pythonpath_dbg = $$(ls -d $(CURDIR)/.pybuild/pythonX.Y-dbg_$(1)/build)
-
 %:
 	dh $@ --with python3 --buildsystem=pybuild
 
@@ -35,25 +29,8 @@
 	dh_sip3
 
 override_dh_auto_test:
-# Run self tests. The current directory is used as the resource
-# directory as veusz hasn't been installed when this is run.
-ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
-	set -e -x;\
-	for py in $(PYVERS); do \
-		LC_ALL=C \
-		PYTHONPATH=$(call pythonpath,$$py) \
-		VEUSZ_RESOURCE_DIR=. \
-			xvfb-run -a \
-			--server-args "-screen 0 640x480x24" \
-			python$$py tests/runselftest.py ;\
-		LC_ALL=C \
-		PYTHONPATH=$(call pythonpath_dbg,$$py) \
-		VEUSZ_RESOURCE_DIR=. \
-			xvfb-run -a \
-			--server-args "-screen 0 640x480x24" \
-			python$$py-dbg tests/runselftest.py ;\
-	done
-endif
+	VEUSZ_RESOURCE_DIR=. xvfb-run -a --server-args "-screen 0 640x480x24" \
+	dh_auto_test -- --system=custom --test-args='{interpreter} {dir}/tests/runselftest.py'
 
 override_dh_strip:
 	dh_strip -pveusz --dbg-package=veusz-dbg
-- 
Piotr Ożarowski                         Debian GNU/Linux Developer
www.ozarowski.pl          www.griffith.cc           www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645


Reply to: