Re: python-networkx_1.10-1_amd64.changes ACCEPTED into experimental
On Wed, Sep 30, 2015 at 9:12 AM, Thomas Goirand <zigo@debian.org> wrote:
> On 09/29/2015 02:11 PM, Sandro Tosi wrote:
>>> Are
>>> there any specific changes you object to
>>
>> As for the technical aspects, tests were disabled mentioning they
>> access internet (and from the code it is not clear at all if they do,
>> and I kinda doubt that)
>
> It clearly showed access to the outside world when it wasn't blacklisted.
really? I re-enabled the test, and this is what I got (pasting and
line wrapping will suck):
File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_agraph.py",
line 218, in networkx.drawing.nx_agraph.graphviz_layout
Failed example:
pos=nx.graphviz_layout(G)
Exception raised:
Traceback (most recent call last):
File "/usr/lib/python2.7/doctest.py", line 1315, in __run
compileflags, 1) in test.globs
File "<doctest networkx.drawing.nx_agraph.graphviz_layout[1]>",
line 1, in <module>
pos=nx.graphviz_layout(G)
File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_pydot.py",
line 257, in graphviz_layout
return pydot_layout(G=G,prog=prog,root=root,**kwds)
File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_pydot.py",
line 271, in pydot_layout
pydot = load_pydot()
File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_pydot.py",
line 47, in load_pydot
raise ImportError(msg)
ImportError: pydot could not be loaded: http://code.google.com/p/pydot/
is this what you call "clearly showed access"? did you even look at
the code? It is just an indication where to download pydot since it
cannot be found when running the test.... disabling the test is
*wrong* adding a build-dep is *right*.
Fix your mistakes or refrain from changing packages you dont
understand or care to maintain.
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: