Re: Looking for a sponsor, just dput python-django-bootstrap to mentors.debian.net
Hi Caio,
On Fri, Dec 5, 2014 at 6:45 AM, Caio Begotti <caio.begotti@canonical.com> wrote:
> Hi everyone! I just dput python-django-bootstrap to
> https://mentors.debian.net/package/django-bootstrap3 and marked it as
> needing a sponsor to review it etc. Would you be interested in it?
>
> I was not sure if this team had a different policy for RFS or what, so I
> decided to send this e-mail anyway hoping you guys would let me know if I
> did the wrong thing :-)
AFAIK there's no team-specific RFS policy. From what I've seen though,
sponsorship within the DPMT/PAPT often takes place via IRC (OFTC,
#debian-python), and relatively few RFS requests come through the
mailing list. I only saw this because I'm trying to work through my
email backlog at the moment...
Anyways, here's a quick review of your package:
- please file an ITP bug report [1] and close it in debian/changelog.
New packages should only have a single, short changelog entry
(typically something like "Initial release (Closes: #xxxxxx)").
- debian/clean seems to be redundant with your override target in d/rules
- Vcs-{Svn,Browser} is missing in d/control; please apply for access
to the DPMT's svn repo at Alioth and upload (and maintain) your
package there, then add the missing Vcs-* fields to d/control
- I suggest following DEP-5 [3] for d/copyright, but that's up to you.
However, you should either have the full upstream license text in
d/copyright, or if it's a license available in
/usr/share/common-licenses, explicitly provide a link to the
appropriate license file. You also seem to be missing a
copyright+license statement for the packaging itself (debian/*).
- some issues caught by lintian that you can easily fix:
P: django-bootstrap3 source: no-dep5-copyright
P: python-django-bootstrap: no-upstream-changelog
I: python-django-bootstrap: extended-description-is-probably-too-short
I: python-django-bootstrap: possible-documentation-but-no-doc-base-registration
(HISTORY.rst looks like an upstream changelog to me)
- the build log contains a bunch of import errors when the docs are
built (i.e. "ImportError: No module named django") - missing
build-dep?
Regards,
Vincent
[1] https://www.debian.org/devel/wnpp/
[2] https://alioth.debian.org/project/request.php?group_id=30714
[3] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Reply to: