[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: pytaglib: looking for a sponsor



Hi Michael,

here is my incomplete review of pytaglib.

On 2013-03-04 15:05:09, Michael Helmling wrote:
> I am looking for a sponsor for my "pytaglib" package, which is a library for 
> accessing metadata ("tags") of audio files.
> 
> Pytaglib essentially binds two functions of the popular TagLib C++ library 
> which were introduced in version 1.8, providing a unified, format-independent 
> way of reading and writing arbitrary tags. In my opininon this makes pytaglib 
> very small (and thus easy to maintain) yet powerfull because you can do 
> virtually anything you want without having to care about the particular file 
> format.
> 
> The library is available for both python2 and python3. Packages have been 
> uploaded to mentors (https://mentors.debian.net/package/pytaglib) as well as 
> the python-modules SVN repository. As far as I can tell, there are no formal 
> problems left in the package, at least lintian does not complain.
> 
> I'd be happy if anyone would be willing to sponsor the package. The bindings 
> are written in Cython, so it might be beneficial if a potential sponsor has 
> come across that software, although the code should be well-readable by anyone 
> who understands python and perhaps a little C++.
> 
> Comments, criticism and questions are generally welcome. :-)

 * How does pytaglib compare to python-tagpy?

 * Why Priority: extra? I'd use optional.

 * AFAICT there is need to list libtag1c2a (>= 1.8) in python(3)-taglib's
   Depends. That's what dh_shlibdeps will create anyway since pytaglib is
   using symbols from >= 1.8.

 * Is this really Python >= 2.7 only? The only things that look
   incompatible to 2.6 are in setup.py and can be fixed easily.

 * Please build the extensions also for the debug interpreter and
   ship them in python(3)-taglib-dbg.

 * Is there a reason why the files listed in extend-diff-ignore aren't
   just removed in the clean target?

 * lintian4py emits:

    p: python3-taglib: SOURCES.txt-in-binary-package
    p: python-taglib: SOURCES.txt-in-binary-package

 * The GPL-3 paragraph is missing the part starting with "This program
   is distributed ..." and it should also refer to
   /usr/share/common-licenses/GPL-3.

 * doc/pyprinttags.1 is Copyright 2013. That's missing in
   debian/copyright. Other files also have Copyright something-2013.

Regards
-- 
Sebastian Ramacher

Attachment: signature.asc
Description: Digital signature


Reply to: