Re: pyxs review
El 08/11/12 23:08, Jakub Wilk escribió:
Hello
New package available at https://mentors.debian.net/package/pyxs
> There are two technical problems with your repacked .orig.tar: - You
> should not include the .git directory. - There should be a single
> top-level directory, so that the tarball can be easily extracted
> manually.
> I see that the tarball now includes the LGPL license. This is good,
> but note that it's not a standalone license; it's merely a set of
> extra permissions to the GPL license. Please ask upstream to include
> GPL license in their VCS/tarballs, too.
Fixed.
Upstream included the LICENSE in the tagged changeset so I started to
use upstream tarball.
md5sum of .tar.gz from github differs from that of the .tar.gz generated
by gbp.
It's something odd. The tar themselves have the same sums, it's the
gzipping what introduces the difference.
The first byte differing between both .tar.gz is at offset 0x08[1], the
archive from github have value 0x00, the one generated by gbp have value
0x02. Any suggestion?
Anyway I provided a get-orig-source following recommendation from Policy
4.9. I hope it will be enough.
> runtests.py contains a gigantic pickled blob. I suppose it contains
> pytest code (though I don't know for sure; there's no easy and
> secure way to unpickle stuff!). If this is the case, that'd violation
> of DFSG§2.
The blob was removed by upstream.
> I'd advise you not to use a more restrictive license than upstream
> uses.
> Current standards version is 3.9.4 (but note that lintian is now
> aware of it yet).
Fixed.
> Upstream provides documentation, it would be a good idea to build
> and install it into the binary package. I see there are also some
> examples in the tarball; it might be worth shipping them in .deb,
> too.
examples/ and docs/ are included now in the package.
> Upstream includes a test suite. Please run it at build time, ideally
> using all supported Python versions.
Fixed. There are many test cases skipped because they depend on a
working dom0/xenstore enviroment.
> You might want also provide
> DEP-8 tests.
Current package doesn't include anyone. Could you give some example of
any DEP-8 test worth including?
> lintian emits: I: python-pyxs:
> description-synopsis-might-not-be-phrased-properly I: python-pyxs:
> extended-description-is-probably-too-short
Fixed.
> lintian4python emits: i: pyxs source: python-stdeb-boilerplate
> debian/rules:3 "This file was automatically generated by stdeb
> 0.6.0+git"
Fixed.
> e: python-pyxs: pyflakes-undefined-name
> usr/share/pyshared/pyxs/_compat.py:74: Monitor
Fixed by upstream.
Worth noting that LibraryStyleGuide[2] was very helpful.
Regards,
maykel
[1] http://www.onicos.com/staff/iz/formats/gzip.html
[2] http://wiki.debian.org/Python/LibraryStyleGuide
Reply to: