Re: RFR: python-astropy -- Core functionality for performing astrophysics with Python

[Jakub Wilk <jwilk@debian.org>]

* Ole Streicher <debian-devel@liska.ath.cx>, 2013-02-12, 14:46:
> http://mentors.debian.net/debian/pool/main/p/python-astropy/python-astropy_0.2~b2-1.dsc

Where can I download .orig.tar from? uscan says: "Newest version on 
remote site is 0.1, local version is 0.2~b2"


debian/control contains a mixture of tabs and spaces, ewww.

Typo in the package description: affilated -> affiliated.

Why do these need to be listed explicitly in Depends?
libcfitsio3, libexpat1, libsofa-c0, zlib1g


Why do you ignore errors from dh_sphinxdoc?

Please run tests only if DEB_BUILD_OPTIONS=nocheck is unset.

Please run tests against all supported Python versions, not only the 
default one.


You shouldn't write "see above" in a DEP-5 copyright file. If you don't 
want to duplicate license text twice, use a stand-alone license 
paragraph.

DEP-5 short license names cannot contains spaces.


The package FTBFS here:
|  debian/rules build
| dh build --with python2,sphinxdoc
|    dh_testdir
|    dh_auto_configure
|    debian/rules override_dh_auto_build
| make[1]: Entering directory `/build/python-astropy-jrJ5eX/python-astropy-0.2~b2'
| dh_auto_build -- --use-system-libraries --enable-legacy
| Freezing version number to astropy/version.py
| Traceback (most recent call last):
|   File "setup.py", line 82, in <module>
|     package_dirs)
|   File "/build/python-astropy-jrJ5eX/python-astropy-0.2~b2/astropy/setup_helpers.py", line 866, in update_package_files
|     extensions.extend(setuppkg.get_extensions())
|   File "astropy/utils/xml/setup_package.py", line 25, in get_extensions
|     ['expat'], ['expat'], include_dirs, library_dirs, libraries)
|   File "/build/python-astropy-jrJ5eX/python-astropy-0.2~b2/astropy/setup_helpers.py", line 1247, in pkg_config
|     output = subprocess.check_output(command, shell=True)
| AttributeError: 'module' object has no attribute 'check_output'
| dh_auto_build: python2.6 setup.py build --force --use-system-libraries --enable-legacy returned exit code 1
| make[1]: *** [override_dh_auto_build] Error 1
| make[1]: Leaving directory `/build/python-astropy-jrJ5eX/python-astropy-0.2~b2'


lintian4python emits:
i: python-astropy source: python-provides-considered-harmful python-astropy
i: python-astropy source: python-provides-considered-harmful python-astropy-legacy

--
Jakub Wilk