Re: RFR: cairosvg -- SVG converter based on Cairo

[Michael Fladischer <michael@fladi.at>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jakub,

thanks for your input!

On 06/08/2012 04:19 PM, Jakub Wilk wrote:
> No, it's not really correct. /usr/bin/cairosvg has currently 
> #!/usr/bin/python2.7 (sic!) shebang, so it won't work out-of-the
> box if only python-ciarosvg is installed.
> 
> I would recommend you to get rid of the -common package and use 
> alternatives to manage /usr/bin/cairosvg symlink, that would point 
> either to #!/usr/bin/python or #!/usr/bin/python3 script.

I switched to alternatives. setuptools seem to be responsible for
changing the shebang line in bin/cairosvg. I'm tempted to change it to
"#!/usr/bin/python" instead of "#!/usr/bin/python2.7" but this would
require meddling with the dependencies. But now the binary package
depends on python2.7 while it should also work with python2.6 alone.
Same for python3.2.

> Re fix_setup.patch, what was wrong with the original code?

Running setup.py clean with python3.2 fails:

Traceback (most recent call last):
  File "setup.py", line 24, in <module>
    VERSION = re.search("VERSION = '([^']+)'", fd.read().strip()).group(1)
  File "/usr/lib/python3.2/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position
68: ordinal not in range(128)

> Some dependencies are missing:

I've added them and I'll issue the RFS soon.

Cheers,
- -- 
Michael Fladischer <michael@fladi.at>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/VuQAACgkQeJ3z1zFMUGZHygCdG6igy9a/VmxBetgF/JmBMHcG
H7gAn1OWFj7EtNmjjxZxPfX78lry4C5E
=D/2w
-----END PGP SIGNATURE-----