pyxs review
Maykel Moya asked to join DPMT. Here's my preliminary review of pyxs,
the package he wants to maintain within the team. (Note that I don't
intend to sponsor this, sorry!)
I downloaded the package from:
http://mentors.debian.net/debian/pool/main/p/pyxs/pyxs_0.3+git20111205.793e02c0-2.dsc
There are two technical problems with your repacked .orig.tar:
- You should not include the .git directory.
- There should be a single top-level directory, so that the tarball can
be easily extracted manually.
If you don't use prisite upstream tarballs, debian/rules should have a
get-orig-source target.
I see that the tarball now includes the LGPL license. This is good, but
note that it's not a standalone license; it's merely a set of extra
permissions to the GPL license. Please ask upstream to include GPL
license in their VCS/tarballs, too.
runtests.py contains a gigantic pickled blob. I suppose it contains
pytest code (though I don't know for sure; there's no easy and secure
way to unpickle stuff!). If this is the case, that'd violation of
DFSG§2.
Now some less severe problems:
I'd advise you not to use a more restrictive license than upstream uses.
Current standards version is 3.9.4 (but note that lintian is now aware
of it yet).
Upstream provides documentation, it would be a good idea to build and
install it into the binary package. I see there are also some examples
in the tarball; it might be worth shipping them in .deb, too.
Upstream includes a test suite. Please run it at build time, ideally
using all supported Python versions. You might want also provide DEP-8
tests.
lintian emits:
I: python-pyxs: description-synopsis-might-not-be-phrased-properly
I: python-pyxs: extended-description-is-probably-too-short
lintian4python emits:
i: pyxs source: python-stdeb-boilerplate debian/rules:3 "This file was automatically generated by stdeb 0.6.0+git"
e: python-pyxs: pyflakes-undefined-name usr/share/pyshared/pyxs/_compat.py:74: Monitor
--
Jakub Wilk
Reply to: