Re: [Debian-med-packaging] librcsb-core-wrapper read for inspection
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dear Jakub!
Thanks for the advice!:
On 17/08/12 16:00, Jakub Wilk wrote:
> * Laszlo Kajan <lkajan@rostlab.org>, 2012-08-16, 21:07:
>> I am ready with librcsb-core-wrapper for inspection.
>
> As per Python Policy §2.2, the binary package name should be python-corepywrap. (If that sounds awfully generic to you, then it's only because
> the module name upstream chose is like that...)
Ok, it is python-corepywrap now.
>
> I recommend not using ${python:Provides}. See
> <http://lists.debian.org/20110324164804.GA5919@jwilk.net> for rationale.
I removed it.
>
> Lintian says:
>
> W: python-librcsb-core-wrapper: hardening-no-fortify-functions usr/lib/python2.6/dist-packages/CorePyWrap.so
> W: python-librcsb-core-wrapper: hardening-no-fortify-functions usr/lib/python2.7/dist-packages/CorePyWrap.so
>
> which might be false-positive, but on the other hand blhc seems to confirm that *FLAGS are lost somewhere:
>
> CFLAGS missing (-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security): libtool --mode=compile gcc
> -D_FORTIFY_SOURCE=2 -O -fPIC -DHAVE_STRCASECMP -DINCL_TEMPLATE_SRC -DHAVE_PLACEMENT_NEW -I./include -I../include -DPOSIX_MISTAKE -c
> src/regcomp.c -o ./obj/regcomp.o
> [snip - more complaints about CFLAGS missing]
> LDFLAGS missing (-Wl,-z,relro): g++ -D_FORTIFY_SOURCE=2 -w -L/usr/lib obj/xml2mmcif.o ../lib/pdbml-parser.a ../lib/dict-obj-file.a
> ../lib/cif-file-util.a ../lib/cif-file.a ../lib/cifparse-obj.a ../lib/tables.a ../lib/common.a ../lib/regex.a -lxerces-c -lm -o ./bin/xml2mmcif
>
Ok, I tried to address this. svn-buildpackage | tee ... blhc does not report anything for me now. The gcc/g++ lines look right to my eyes. But I
still get the lintian warning! *What can I do now?*
> dh_python2 manpage says that python-all-dev build-dependency should be
> versioned: (>= 2.6.6-3~). That's only needed to be pedantically correct,
> because the needed version is already in squeeze.
Done.
>
> It's customary to build extension modules also with python2.X-dbg interpreters, and put them into a separate python-foo-dbg package. If you
> build-depend on python-all-dbg then dh_auto_* will do most of the work for you. (It's a feature added in debhelper 7.3.5, so you should bump
> debhelper build-dependency if you decide to use it.)
>
Ok, I added this. Building the wrapper (the binding) is painfully slow... it's a pity the four versions of this module can not be built in parallel.
Best regards,
Laszlo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQLnZpAAoJEJvS1kCaDFL6t34P/jmb3Dv71bh4sfmsw+f3nytT
UhUeCHW7dZ29A6uQM7VV/L3ES13LYLb6SigNy1QkGBhbw97jmxhvmXeuIRD1P3qx
IYs3Ci+gVvwEIBX07gW5cO2/D16iwMIa63EBOzGv0DDumJISJHlHhV4wyn0Ocqvh
k4WSuas7JbwDm9v+CnJ7N4+btfdugz92xPUAWmlDMdcGKbXxyNPZcq2lqRVxMr4u
nTqwEmYA78YjEOKgcSVAp/ih+s8fLPKtGAx9GpUeBU0DMNumQgfMWHeNb/I6MCFC
f+tPySmRGzboxPbtsjRh1p27d7EI16+q6n3AwvKq8UG+XAWkbHOvn7T4Myh68U0e
JUcX6KOQDWtUSh9p4sP0uaVpiGzwdfGzpl5usX+Fptlf/h2tjDDfKhnEHXOkPIxN
33wLqJawlPLy/Y+7PbrmagduPc9qdFwr9WkLTrKpmYafs4t8G6zXKmipqhBJXJFg
V9UeJJY2xr/Gwoeiq1xcx3dXddpQDGrX4s50h9mgGHS7uwsz/vAdrAxZMbkxTxdR
Xkd8j6sgdZM56ZH5rj6k9pZjJKE4cGfu89NvgrPOb0s0TXdacSNSPVtImmdeCjSS
ZvUGxpWhQsLTwrMkPRf4OzXsSzjoTyKHLJtvVSzQant8SgqJ7o339jb9KRWjUjYk
YGIgi0YlpHSS8ledq/si
=K+Vt
-----END PGP SIGNATURE-----
Reply to: