[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: dparser-1.16-1 [ITP] -- a scannerless GLR parser generator

Please use X-Debbugs-Cc instead of regular Cc when filing bugs:

I don't intend to sponsor this package, but here's my review:

* Markus Wanner <markus@bluegap.ch>, 2012-04-16, 07:45:

base-makefile-fixes.patch removes this line:
LIBS += -lm
But this is explained neither in the patch description nor in the changelog.

The fix-python-makefile patch will break if Python version is longer than 3 characters. (I know, unlikely, but it still bothers me. ;P) You could query distutils directly for the build directory using the following code:

python -c 'from distutils.command.build import build; from distutils.core import Distribution; b = build(Distribution()); b.finalize_options(); print b.build_platlib'

More importantly, the fix-python-makefile patch violates Policy §4.6.

Oh, and please don't add commented-out code, thanks.

Have you forwarded the manpage-hyphen-correction patch upstream?

Why priority extra? I'd use optional.

I'd rather not use ${python:Provides}. See: http://lists.debian.org/20110324164804.GA5919@jwilk.net

In debian/copyright, you need to either add newlines (escaped by dots) between list items or indent the whole list by an extra space. (License uses the same rules as Description in debian/control; see Policy §5.6.13 for details.)

Please honour DEB_BUILD_OPTIONS=nocheck.

Please honour DEB_BUILD_OPTIONS=noopt.

This part of upstream makefile:

ifeq ($(ARCH),x86_64)

smells like a violation of Policy §10.2.

The package fails to build in a minimal environment:

python2.6 setup.py build
make[2]: python2.6: Command not found
make[2]: *** [all] Error 127

I see lots of
make[3]: svnversion: Command not found
in the build log. Is that intentional?

What is debian/dparser-doc.install for?

Version declared in setup.py is 1.9. Shouldn't that be 1.26?

Jakub Wilk

Reply to: