[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS nuitka



Happy New Year!

so let's begin ;)

1. version
0.3.17pre2-1

if 'pre' means  prior 0.3.17, then make it 0.3.17~pre2-1 otherwise
it would sort after (use dpkg --compare-versions  in cmdline if you want
to check for sure how versions get sorted)

2.  debian/copyright

a. separate main copyright statement into separate paragraph (separated
with empty line) with

Files: *

b. nuitka/build/static_src/arm_ucontext_src/getcontext.asm

you should copy that MIT style license verbatim into debian/copyright
and also that file contains 1 more copyright/license for some snippets
in the code of that file

3.  debian/patches/remove-inline-scons

removing scons with patch like this is not quite the right way... two
possibilities

i. don't remove scons but just (minimalistic patch) make system wide
used

  then you would need still to add its copyright/license into
  debian/copyright, just add a comment that those are not used

ii (somewhat preferable). remove scons from within .orig.tar.gz
(optionally add +dfsg or .dfsg suffix to the version making it
0.3.17~pre2+dfsg-1)


4. go through the output of licensecheck -r --copyright .
and fill entries for them in debian/copyright: e.g. I find things like

./tests/benchmarks/pybench/pybench.py: UNKNOWN
  [Copyright: , 2000-2006, eGenix.com Software GmbH (info@egenix.com) / , 1997-2006, Marc-Andre Lemburg (mal@lemburg.com) / assignment to the code, or in the]

5. you do have unittests, why don't excercize them during build time
(override_dh_auto_test)?  that would assure that it functions correctly
across releases (and architectures if anyone rebuilds it there ;) )

sorry -- now family time 

otherwise FWIW package seems to build nicely across most of recent
debian/ubuntu releases:

nuitka_0.3.17pre2-1_amd64.build OK  0:39.27 real, 23.32 user, 11.13 sys, 337464 out
nuitka_0.3.17pre2-1~nd50+1_amd64.build  FAILED  0:10.87 real, 3.24 user, 2.25 sys, 55704 out
nuitka_0.3.17pre2-1~nd60+1_amd64.build  OK  0:35.42 real, 19.53 user, 9.62 sys, 220960 out
nuitka_0.3.17pre2-1~nd70+1_amd64.build  OK  0:40.50 real, 24.46 user, 10.47 sys, 326920 out
nuitka_0.3.17pre2-1~nd+1_amd64.build    OK  0:40.20 real, 24.28 user, 10.22 sys, 325848 out
nuitka_0.3.17pre2-1~nd08.04+1_amd64.build   FAILED  0:13.14 real, 4.48 user, 3.13 sys, 63792 out
nuitka_0.3.17pre2-1~nd09.10+1_amd64.build   FAILED  0:13.52 real, 3.88 user, 3.03 sys, 69544 out
nuitka_0.3.17pre2-1~nd10.04+1_amd64.build   FAILED  0:19.92 real, 5.42 user, 4.86 sys, 83824 out
nuitka_0.3.17pre2-1~nd10.10+1_amd64.build   FAILED  0:14.55 real, 5.64 user, 3.40 sys, 94560 out
nuitka_0.3.17pre2-1~nd11.04+1_amd64.build   OK  0:59.51 real, 35.69 user, 16.09 sys, 211232 out
nuitka_0.3.17pre2-1~nd11.10+1_amd64.build   OK  0:50.39 real, 30.28 user, 14.37 sys, 369608 out




On Sat, 31 Dec 2011, Kay Hayen wrote:


> Dear Debian Python Team,

> I am out of review comments for the package of mine:

>  * Package name    : nuitka
>    Version         : 0.3.17pre2-1
>    Upstream Author : Kay Hayen <kayhayen@gmx.de>
>  * URL             : http://nuitka.net
>  * License         : GPLv3
>    Section         : python

> It builds those binary packages:

> nuitka     - Python compiler with full language support and CPython
> compatible

> To access further information about this package, please visit the
> following URL:

>   http://mentors.debian.net/package/nuitka

> Alternatively, one can download the package with dget using this command:

>   dget -x http://mentors.debian.net/debian/pool/main/n/nuitka/nuitka_0.3.17pre2-1.dsc

> I would be glad if someone uploaded this package for me. I believe
> it relatively is simple package. No real compile time dependencies.
> Pure Python. Lintian clean. Closes an ITP bug, etc.

> At Python compile time, it uses g++ and Scons, but without the user
> noticing. Esp. Nuitka is not itself build with Scons, nor needs the
> user use it, etc. There is a inline copy of Scons in Nuitka, which
> is removed for Debian of course, and not in the binary build.

> I am willing to be a "good" upstream, and have so far made all known
> modifications to fit better into Debian. My intention is to become a
> "Debian Maintainer" for this package.

> Thanks in advance,
> Kay Hayen
-- 
=------------------------------------------------------------------=
Keep in touch                                     www.onerussian.com
Yaroslav Halchenko                 www.ohloh.net/accounts/yarikoptic


Reply to: