Re: need someone to review and upload my package python-pycaptcha
* Olivier Sallou <olivier.sallou@irisa.fr>, 2011-08-10, 08:39:
I need a DD to upload (and review)
(Hopefully in the reverse order! :P)
I'm not interested in uploading it, but here's my (cursory) review:
- Binary package name is wrong; see Python Policy 2.2. Also, I'd use the
name upstream uses (pycaptcha) for source package name.
- python-all is needed in the clean target, so in must be in Build-Depends, not
Build-Depends-Indep.[0]
- Did you intend to use dh_python2? (You currently use python-support
without build depending on it...)
- You don't need get-orig-source target if only calls uscan.
- Use "debhelper (>= 8)" rather than "debhelper (>= 8.0.0)" to ease
backporting.
- Remove "DEB_PYTHON_INSTALL_ARGS_ALL += ..." from your debian/rules, it does
nothing.
I tested with lintian and pbuilder.
Oh, did you? :) My lintian complains heavily:
P: python-pycaptcha: no-upstream-changelog
I: python-pycaptcha: extended-description-is-probably-too-short
I: python-pycaptcha: capitalization-error-in-description python Python
W: python-pycaptcha: image-file-in-usr-lib usr/lib/python2.6/dist-packages/Captcha/data/pictures/abstract/1.jpeg
W: python-pycaptcha: image-file-in-usr-lib usr/lib/python2.6/dist-packages/Captcha/data/pictures/abstract/10.jpeg
W: python-pycaptcha: image-file-in-usr-lib usr/lib/python2.6/dist-packages/Captcha/data/pictures/abstract/11.jpeg
[snip - 27 more image-file-in-usr-lib...]
W: python-pycaptcha: extra-license-file usr/share/doc/python-pycaptcha/COPYING
[0] Separating B-D and B-D-I is often tricky, and if a package builds
only arch:all binaries there's only very little benefit from the
separation. So my general advice is: use only B-D (unless you know what
you are doing).
--
Jakub Wilk
Reply to: