[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: mercurial 1.1.2



[Vernon Tang, 2009-01-04]
> I've updated the mercurial package to 1.1.2. Apart from that I've tried to 
> clean the package up quite a bit, so for now my changes are in 
> branches/1.1-vt.
> 
> I'd appreciate it if someone would review my changes and sponsor the upload.

you want it to be uploaded to experimental for now, right? (note that
there are many rev. dependencies)

PAPT is in Maintainer field, but you've made many changes so I'm CCing 
guys listed in Uploaders hoping that they will take a look
(if you'll add yourself to Uploaders, I will not wait for their reply)

also:
* why did you bump required debhelper compatibility? I don't see any
  dh7's features in debian/rules (this change is not mentioned in
  debian/changelog, BTW)
* isn't python-openssl missing in Recommends or Suggests?
  (see f.e. mercurial/hgweb/server.py, line 182)
* how about: s/python help/Python help/ in debian/changelog
* in debian/control: s/Description: Scalable/Description: scalable
* could you add comments to patches?
* why not use trunk (IMHO there's no need to use new branch)

-- 
-=[     Piotr Ożarowski     ]=-
-=[ http://www.ozarowski.pl ]=-

Attachment: pgpuIhVeEgfb1.pgp
Description: PGP signature


Reply to: