[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1057793: marked as done (ipp-usb: delegate placement of systemd/udev files to pkg-config data)

Your message dated Thu, 13 Jun 2024 16:19:05 +0000
with message-id <E1sHnAH-00FX4z-2i@fasolo.debian.org>
and subject line Bug#1057793: fixed in ipp-usb 0.9.23-1.1
has caused the Debian Bug report #1057793,
regarding ipp-usb: delegate placement of systemd/udev files to pkg-config data
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1057793: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057793
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: ipp-usb
Version: 0.9.23-1
Severity: normal
Tags: patch
User: helmutg@debian.org
Usertags: dep17m2

Dear Maintainer,

your package installs files related to systemd and udev, into /lib.
These files need to be moved to /usr/lib as part of Debian's
usr-merge effort [1].

Attached you will find a patch to delegate the exact placement to
systemd.pc/udev.pc (using pkg-config). This should work today in
unstable and, if necessary, for bookworm. Once udev.pc in unstable
points to /usr/lib your package will benefit automatically after a
binNMU or any other upload. systemd.pc in unstable already points to
/usr/lib.

Note: this patch does NOT move /sbin/ipp-usb. At the time of writing
unstable is not ready for such a change. Depending on when you merge
this, moving /sbin/ipp-usb to /usr/sbin might also be appropriate.

Later during the trixie cycle I expect this bug class to raise in
priority.

Per the wiki, it is advisable to upload to experimental first, and
wait a few days for the dumat tool to check your package. The same
is advisable when any structural changes are done in the trixie
cycle.

Thank you for considering,
Chris

[1] https://wiki.debian.org/UsrMerge

diff -Nru ipp-usb-0.9.23/debian/changelog ipp-usb-0.9.23/debian/changelog
--- ipp-usb-0.9.23/debian/changelog	2022-12-07 12:26:08.000000000 +0100
+++ ipp-usb-0.9.23/debian/changelog	2023-12-08 16:09:18.000000000 +0100
@@ -1,3 +1,10 @@
+ipp-usb (0.9.23-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Delegate placement of udev/systemd files to pkg-config data
+
+ -- Chris Hofstaedtler <zeha@debian.org>  Fri, 08 Dec 2023 16:09:18 +0100
+
 ipp-usb (0.9.23-1) unstable; urgency=medium
 
   * Update to new upstream version 0.9.23.
diff -Nru ipp-usb-0.9.23/debian/control ipp-usb-0.9.23/debian/control
--- ipp-usb-0.9.23/debian/control	2022-12-07 12:25:07.000000000 +0100
+++ ipp-usb-0.9.23/debian/control	2023-12-08 16:09:18.000000000 +0100
@@ -13,6 +13,7 @@
  libusb-1.0-0-dev,
  pkg-config,
  ronn,
+ systemd-dev,
 Standards-Version: 4.6.0
 Rules-Requires-Root: no
 Homepage: https://github.com/OpenPrinting/ipp-usb
diff -Nru ipp-usb-0.9.23/debian/patches/0002-Use-pkg-config-for-systemd-dev-paths.patch ipp-usb-0.9.23/debian/patches/0002-Use-pkg-config-for-systemd-dev-paths.patch
--- ipp-usb-0.9.23/debian/patches/0002-Use-pkg-config-for-systemd-dev-paths.patch	1970-01-01 01:00:00.000000000 +0100
+++ ipp-usb-0.9.23/debian/patches/0002-Use-pkg-config-for-systemd-dev-paths.patch	2023-12-08 16:09:05.000000000 +0100
@@ -0,0 +1,24 @@
+Index: ipp-usb-0.9.23/Makefile
+===================================================================
+--- ipp-usb-0.9.23.orig/Makefile
++++ ipp-usb-0.9.23/Makefile
+@@ -1,6 +1,8 @@
+ MANDIR    = /usr/share/man/
+ QUIRKSDIR = /usr/share/ipp-usb/quirks
+ MANPAGE   = ipp-usb.8
++SYSTEMDSYSTEMUNITDIR = $(shell pkg-config --variable=systemdsystemunitdir systemd)
++UDEVDIR   = $(shell pkg-config --variable=udevdir udev)
+ 
+ # Merge DESTDIR and PREFIX
+ PREFIX := $(abspath $(DESTDIR)/$(PREFIX))
+@@ -19,8 +21,8 @@ $(MANPAGE): $(MANPAGE).md
+ 
+ install:
+ 	install -s -D -t $(PREFIX)/sbin ipp-usb
+-	install -m 644 -D -t $(PREFIX)/lib/udev/rules.d systemd-udev/*.rules
+-	install -m 644 -D -t $(PREFIX)/lib/systemd/system systemd-udev/*.service
++	install -m 644 -D -t $(PREFIX)$(UDEVDIR)/rules.d systemd-udev/*.rules
++	install -m 644 -D -t $(PREFIX)$(SYSTEMDSYSTEMUNITDIR) systemd-udev/*.service
+ 	install -m 644 -D -t $(PREFIX)/etc/ipp-usb ipp-usb.conf
+ 	mkdir -p $(PREFIX)/$(MANDIR)/man8
+ 	gzip <$(MANPAGE) > $(PREFIX)$(MANDIR)/man8/$(MANPAGE).gz
diff -Nru ipp-usb-0.9.23/debian/patches/series ipp-usb-0.9.23/debian/patches/series
--- ipp-usb-0.9.23/debian/patches/series	2022-12-07 12:26:08.000000000 +0100
+++ ipp-usb-0.9.23/debian/patches/series	2023-12-08 16:06:30.000000000 +0100
@@ -1 +1,2 @@
 0001-Revert-make-install-made-dependent-on-make-all.patch
+0002-Use-pkg-config-for-systemd-dev-paths.patch

--- End Message ---
--- Begin Message --- 
Source: ipp-usb
Source-Version: 0.9.23-1.1
Done: Chris Hofstaedtler <zeha@debian.org>

We believe that the bug you reported is fixed in the latest version of
ipp-usb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1057793@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Hofstaedtler <zeha@debian.org> (supplier of updated ipp-usb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 30 May 2024 17:30:20 +0200
Source: ipp-usb
Architecture: source
Version: 0.9.23-1.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Team <debian-printing@lists.debian.org>
Changed-By: Chris Hofstaedtler <zeha@debian.org>
Closes: 1057793
Changes:
 ipp-usb (0.9.23-1.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Delegate placement of udev/systemd files to pkg-config data
     (Closes: #1057793)
Checksums-Sha1:
 bfadaf1d3d8473a05e2bdd9a7fb2aa8af5f11b70 2139 ipp-usb_0.9.23-1.1.dsc
 88caa6c047196252520c16274a6e433a4d62523c 4312 ipp-usb_0.9.23-1.1.debian.tar.xz
 4b4056676ce5105c426ec773be2a3ce51b920138 7652 ipp-usb_0.9.23-1.1_arm64.buildinfo
Checksums-Sha256:
 326c6fae041e6f04fd6193671e4760f587e728fa49b2dbd0bb38cea6dec34d7c 2139 ipp-usb_0.9.23-1.1.dsc
 36586400055777a1e55871f846ec07c85b50c5284e6041d6a83302b8e8e1845c 4312 ipp-usb_0.9.23-1.1.debian.tar.xz
 4387043e365ea7227bb0119322488705aa00e8aed979b4451477c19b9ef648fb 7652 ipp-usb_0.9.23-1.1_arm64.buildinfo
Files:
 9e367a83ae291c16ad8cc64232597fe7 2139 comm optional ipp-usb_0.9.23-1.1.dsc
 b3a3bf0548383373c7b739d3dda91ef0 4312 comm optional ipp-usb_0.9.23-1.1.debian.tar.xz
 371f36484e4855685295bd0df929d5ea 7652 comm optional ipp-usb_0.9.23-1.1_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfRrP+tnggGycTNOSXBPW25MFLgMFAmZYnHQACgkQXBPW25MF
LgOCQRAAhqc1PltSpvhvOpMkfG8i6MxRLU8EQHf5J6DWl1cTnPRXyB1ZoeLqRn7Z
9L4MDcOuceI1hPje9Bm92MlMp7dz5IzsQjBrsB+hyyfHnWpZ8aIZ1Gfkg68j8Ojp
rNcIJFWYO4ef3H6DPFRDpwHfbBXR6fYpOQBxWTNek4+3H0mFiSqy2ELjArz/CDAW
uUUyoVU28cQORST/aQa6wF0CJEnOkB1U2B6MAK++pSDvn5ZLpSzjxpAFztnBrRG2
T3yxEfbV/1E5g4vNA/0YvXnV8WF8gEn1iP85CVIiqy0MJEM8jYN/fydUCWMTkKB+
8JN6ky1DsMJoBsCkLWE9/9gHG89IkthI9kXvNs+GA+GfjwMBA6snVCsGezCNh3KG
/AHqhZnmENZI4PyRlhUCb4aV1bxZcLPsy1tpR95jpCvBDGPCSowgDT/4vhzsMvcr
+WHX4RbC+rrn8IN/70/ctqxfJwKpJT+DQOKmZlQHM+5gL1hLeCbWutdjvJpnwdVQ
ryLBZCecxZtBBvuWoP2tLnhbpYokBHgKfxflM1mvjoHKwbVulUz0vXcgVG+gvUqd
L5PEwbVIB0kejrS0SpTZlrA+6DijsiewUbSEdEpwT0jTTBRYO61nn3THaac0yi73
KtWbRZn0eliCRBfVZ9l34RF2ThERc4jkhpuGX+uLFhFClv+LSPw=
=BwaB
-----END PGP SIGNATURE-----

Attachment: pgpg6XyKEc7pq.pgp
Description: PGP signature


--- End Message ---
Reply to: