Bug#1030043: hplip-gui: traceback when launching hp-toolbox
Package: hplip-gui
Version: 3.22.10+dfsg0-1
Severity: grave
Tags: patch
Justification: renders package unusable
Dear Maintainer,
* What led up to the situation?
Trying to launch hp-toolbox software, got this output:
Traceback (most recent call last):
File "/usr/bin/hp-toolbox", line 280, in <module>
toolbox = ui.DevMgr5(__version__, device_uri, None)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/ui5/devmgr5.py", line 238, in __init__
core = CoreInstall(MODE_CHECK)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/installer/core_install.py", line 240, in __init__
self.passwordObj = password.Password(ui_mode)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/base/password.py", line 94, in __init__
self.__readAuthType() # self.__authType
^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/base/password.py", line 119, in __readAuthType
distro_name = get_distro_std_name(os_name)
^^^^^^^^^^^^^^^^^^^
NameError: name 'get_distro_std_name' is not defined. Did you mean: 'get_distro_name'?
* What exactly did you do (or not do) that was effective (or
ineffective)?
I patched the password.py file with the correct function name and
delete the os_name parameter when being called.
* What was the outcome of this action?
Positive. The hp-toolbox launched succesfully.
-- Package-specific info:
Saving output in log file: /home/julien/hp-check.log
HP Linux Imaging and Printing System (ver. 3.22.10)
Dependency/Version Check Utility ver. 15.1
Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.
Note: hp-check can be run in three modes:
1. Compile-time check mode (-c or --compile): Use this mode before compiling the HPLIP supplied tarball (.tar.gz or .run) to determine if the proper dependencies are installed to successfully compile HPLIP.
2. Run-time check mode (-r or --run): Use this mode to determine if a distro supplied package (.deb, .rpm, etc) or an already built HPLIP supplied tarball has the proper dependencies installed to successfully run.
3. Both compile- and run-time check mode (-b or --both) (Default): This mode will check both of the above cases (both compile- and run-time dependencies).
-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (990, 'testing'), (10, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-1-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages hplip-gui depends on:
ii dbus-user-session [default-dbus-session-bus] 1.14.4-1
ii hplip 3.22.10+dfsg0-1
ii python3-dbus.mainloop.pyqt5 5.15.7+dfsg-3+b3
ii python3-pyqt5 5.15.7+dfsg-3+b3
Versions of packages hplip-gui recommends:
ii python3-notify2 0.3-5
ii simple-scan 42.5-2
hplip-gui suggests no packages.
-- no debconf information
--- password.py 2023-01-30 17:15:43.563960616 +0100
+++ /usr/share/hplip/base/password.py 2023-01-15 11:39:02.000000000 +0100
@@ -116,8 +116,7 @@
# added replace() to remove the spaces in distro_name
(os_name,_ver) = utils.get_distro_name() #.lower().replace(" ","")
os_name = os_name.lower().replace(" ","")
- #distro_name = get_distro_std_name(os_name)
- distro_name = get_distro_name()
+ distro_name = get_distro_std_name(os_name)
self.__authType = user_conf.get('authentication', 'su_sudo', '')
if self.__authType != "su" and self.__authType != "sudo":
try:
--- password.py 2023-01-30 17:15:43.563960616 +0100
+++ /usr/share/hplip/base/password.py 2023-01-15 11:39:02.000000000 +0100
@@ -116,8 +116,7 @@
# added replace() to remove the spaces in distro_name
(os_name,_ver) = utils.get_distro_name() #.lower().replace(" ","")
os_name = os_name.lower().replace(" ","")
- #distro_name = get_distro_std_name(os_name)
- distro_name = get_distro_name()
+ distro_name = get_distro_std_name(os_name)
self.__authType = user_conf.get('authentication', 'su_sudo', '')
if self.__authType != "su" and self.__authType != "sudo":
try:
--- password.py 2023-01-30 17:15:43.563960616 +0100
+++ /usr/share/hplip/base/password.py 2023-01-15 11:39:02.000000000 +0100
@@ -116,8 +116,7 @@
# added replace() to remove the spaces in distro_name
(os_name,_ver) = utils.get_distro_name() #.lower().replace(" ","")
os_name = os_name.lower().replace(" ","")
- #distro_name = get_distro_std_name(os_name)
- distro_name = get_distro_name()
+ distro_name = get_distro_std_name(os_name)
self.__authType = user_conf.get('authentication', 'su_sudo', '')
if self.__authType != "su" and self.__authType != "sudo":
try:
Reply to: