[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1000839: marked as done (gutenprint: reproducible builds: Embedded build path, username, timestamps, etc.)

Your message dated Sun, 27 Mar 2022 00:48:42 +0000
with message-id <E1nYH5G-000EZv-CD@fasolo.debian.org>
and subject line Bug#1000839: fixed in gutenprint 5.3.3-8
has caused the Debian Bug report #1000839,
regarding gutenprint: reproducible builds: Embedded build path, username, timestamps, etc.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1000839: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000839
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: gutenprint
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps username uname kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Various information about the build environment is captured in the
config.summary and gutenprint.tag files:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/gutenprint.html

  /usr/share/doc/libgutenprint-doc/reference/gutenprint.tag.gz
  
  <path>/build/1st/gutenprint-5.3.3/include/gutenprint/</path>
  vs.
  <path>/build/2/gutenprint-5.3.3/2nd/include/gutenprint/</path>

  and

  /usr/lib/x86_64-linux-gnu/gutenprint/5.3/config.summary

  Generated·at·Fri·Nov·12·00:38:07·-12·2021·by·pbuilder1
  vs.
  Generated·at·Fri·Dec·16·09:37:41·+14·2022·by·pbuilder2

and

  uname·-a·output: Linux·ionos1-amd64·5.10.0-9-amd64·#1·SMP·Debian·5.10.70-1·(2021-09-30)·x86_64·GNU/Linux
  vs.
  uname·-a·output: Linux·i-capture-the-hostname·5.14.0-0.bpo.2-amd64·#1·SMP·Debian·5.14.9-2~bpo11+1·(2021-10-10)·x86_64·GNU/Linux


The attached two patches fix this by sanitizing the the files from
debian/rules in the dh_installdocs override and dh_install-arch override
targets.

With these patches applied, gutenprint should build reproducibly on
tests.reproducible-builds.org.


On a somewhat unrelated note, I also noticed needing to override
dh_listmissing to only warn rather than fail on missing various
documentation files. I'm not sure if this was due to something in my
specific environment, or a general issue for the package, but figured it
was worth a heads up.


Thanks for maintaining gutenprint!


live well,
  vagrant

From 07e666d4cc4e93395852902610da198ee543852e Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 30 Nov 2021 02:27:28 +0000
Subject: [PATCH 1/2] debian/rules: Remove build paths from gutenprint.tag
 file.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/rules b/debian/rules
index d50deaf..c33e323 100755
--- a/debian/rules
+++ b/debian/rules
@@ -40,6 +40,10 @@ override_dh_installdocs:
 	dh_installdocs -pescputil --link-doc=libgutenprint9
 	dh_installdocs -plibgutenprintui2-dev --link-doc=libgutenprintui2-2
 	dh_installdocs --remaining-packages
+	# Remove build directory from gutenprint.tag file to make
+	# build reproducible.
+	sed -i -e 's,$(CURDIR),BUILDPATH,g' \
+		debian/libgutenprint-doc/usr/share/doc/libgutenprint-doc/reference/gutenprint.tag
 
 override_dh_install-arch:
 ifeq ($(DEB_BUILD_ARCH_OS),linux)
-- 
2.30.2


From 523247408d47590253c46f2119dc09104e972a10 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 30 Nov 2021 02:31:37 +0000
Subject: [PATCH 2/2] debian/rules: Remove build path, timestamp, username and
 uname output from config.summary file.

https://reproducible-builds.org/docs/build-path/
https://reproducible-builds.org/docs/timestamps/
https://tests.reproducible-builds.org/debian/issues/user_hostname_manually_added_requiring_further_investigation_issue.html
https://tests.reproducible-builds.org/debian/issues/captures_kernel_version_issue.html
---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index c33e323..06de18a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -46,6 +46,12 @@ override_dh_installdocs:
 		debian/libgutenprint-doc/usr/share/doc/libgutenprint-doc/reference/gutenprint.tag
 
 override_dh_install-arch:
+	# Remove build path, timestamp, username, and uname output to
+	# make build reproducible.
+	sed -i -e 's,$(CURDIR),BUILDPATH,g' \
+		-e 's,Generated at.*,Generated at REDACTED,g' \
+		-e 's,uname -a output:.*,uname -a output: REDACTED,g' \
+		$(shell find debian/tmp/ -name config.summary)
 ifeq ($(DEB_BUILD_ARCH_OS),linux)
 	dh_install -pprinter-driver-gutenprint usr/share/cups/usb
 endif
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: gutenprint
Source-Version: 5.3.3-8
Done: Thorsten Alteholz <debian@alteholz.de>

We believe that the bug you reported is fixed in the latest version of
gutenprint, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1000839@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thorsten Alteholz <debian@alteholz.de> (supplier of updated gutenprint package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 26 Mar 2022 21:03:02 +0100
Source: gutenprint
Architecture: source
Version: 5.3.3-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Group <debian-printing@lists.debian.org>
Changed-By: Thorsten Alteholz <debian@alteholz.de>
Closes: 1000839 1005627
Changes:
 gutenprint (5.3.3-8) unstable; urgency=medium
 .
   * debian/control: add myself to Uploaders:
   * debian/rules: make package reproducible build (Closes: #1000839)
                   Thanks a lot to Vagrant Cascadian for the patch
   * debian/symbols: yydebug is missing now (Closes: #1005627)
Checksums-Sha1:
 ee0f37bb6f54e491c038c32fe69d97fa5522dd8b 3032 gutenprint_5.3.3-8.dsc
 9be2207a81417cfe3508c16e91b04edcbec61c5d 95604 gutenprint_5.3.3-8.debian.tar.xz
 643492f5db4cd6472d5f39ce857cdb7197f2c8fa 20032 gutenprint_5.3.3-8_amd64.buildinfo
Checksums-Sha256:
 f2b4b91b2a174d3c6f85f6a630f9668b068db6015b9794fa74c0c242d06793d1 3032 gutenprint_5.3.3-8.dsc
 b0fc8d7aadaef930f3f03a09c4d47221b389a67477f56319ad1736a652cbe30b 95604 gutenprint_5.3.3-8.debian.tar.xz
 badbb623c211e1e3acfd929b165fbbd9a7c8438290101e6bb9928a0b8c364073 20032 gutenprint_5.3.3-8_amd64.buildinfo
Files:
 ed3d08310e36baec5563ed9adadede74 3032 graphics optional gutenprint_5.3.3-8.dsc
 b0b310d29f72ac8929b449e290db8b3b 95604 graphics optional gutenprint_5.3.3-8.debian.tar.xz
 2b731f283e405940af99c5cffac7521e 20032 graphics optional gutenprint_5.3.3-8_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKnBAEBCgCRFiEEYgH7/9u94Hgi6ruWlvysDTh7WEcFAmI/sjtfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYy
MDFGQkZGREJCREUwNzgyMkVBQkI5Njk2RkNBQzBEMzg3QjU4NDcTHGRlYmlhbkBh
bHRlaG9sei5kZQAKCRCW/KwNOHtYR/r5D/0U6Hn65KTB6W5wEJXxKR4aVYFbhBF6
T+WQkwYCEZlSe1li0JLyHHeqIQT2htNN6LqfVMI6NlEZtKP6i+HcyJ9EbfDhONL6
wOcUK+BQcXd5R5sETPAa6mC3chQFZel2E/eABiJesGguH/JAMPSy3RTIW7YL3MvO
dkOku8DKlAAeNtfESX4QnOYlUG6K3qsFotFUZCcVAHntX0bpMDPP0tsS9C7XRG5X
ytqJuyLwr5W0xtEVEU/70XO5iRePR4CNIpSYhd5DIeQpPdT1EkyxJTukIMSJH4PK
u3+S6vTYHFOx4XUcM4dzvR4XWv1Vx8Nc5QBBuDGVtA4pNbLeTJjB94jDNQz9H0oU
FMMhbkoLevRwgxKHaaL45mLkaSTDOs+xKxWg3mScXEXBsDCw/c4nqnIeK4kDcEQO
R+3ZqPvfeWajy0tAEQxNXBr2IeSf01GOP7GnqW8J48Hk5DtwcjIX6k1K4v2wIJf5
6ro/DYPcZAnXLLnKeRHS0q7m27WH8YxWm/Mdi9J6O2RyCgw1WGDMOuieSEHhscoJ
a53OgbJqF09AlxPjX6aD753f8s2Di8Kb8SZkBdGr9HeQhbVLVkUN10Jf5gim0dnZ
RqLctG6krP7b50T5axS4UU7XzbwZReVznqlNsmX2/7vCiQjtKIWVq+l86W6uuidw
WxWpZxucl/2U2w==
=ov7a
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: