[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#987493: unblock: gutenprint/5.3.3-5



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: gutenprint@packages.debian.org

This is a pre-approval request for package package gutenprint.

[ Reason ]
It was reported on #987457 that the gutenprint-locales packages contained no…
locales. This has apparently slipped through almost a full release cycle.

Anyway. I'd like to fix this in unstable, by building and installing the .mo
files.

[ Impact ]
No translations for gutenprint.

[ Tests ]
The patch I propose adds a non-regression test in dh_install.

[ Risks ]
I can't think of any, besides taking more disk-space for potentially unused
translations.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

unblock gutenprint/5.3.3-5
diff -Nru gutenprint-5.3.3/debian/changelog gutenprint-5.3.3/debian/changelog
--- gutenprint-5.3.3/debian/changelog	2020-02-17 08:36:42.000000000 +0100
+++ gutenprint-5.3.3/debian/changelog	2021-04-24 17:37:27.000000000 +0200
@@ -1,3 +1,9 @@
+gutenprint (5.3.3-5) unstable; urgency=medium
+
+  * Build and install translations in gettext-locales (Closes: #987457)
+
+ -- Didier Raboud <odyx@debian.org>  Sat, 24 Apr 2021 17:37:27 +0200
+
 gutenprint (5.3.3-4) unstable; urgency=medium
 
   * Backport upstream patch:
diff -Nru gutenprint-5.3.3/debian/rules gutenprint-5.3.3/debian/rules
--- gutenprint-5.3.3/debian/rules	2020-02-17 08:36:42.000000000 +0100
+++ gutenprint-5.3.3/debian/rules	2021-04-24 17:37:27.000000000 +0200
@@ -26,9 +26,15 @@
 	  $(MAINTAINER_MODE) \
 	  --enable-nls
 
+execute_after_dh_auto_build-indep:
+	# Build the gettext translations (#987457)
+	cd po && make update-gmo
+
 override_dh_install-indep:
 	dh_install -i
 	rm -f debian/gutenprint-locales/usr/share/locale/*/*.po
+	# Make sure at least some locales are installed (#987457)
+	test -n "$$(find debian/gutenprint-locales/usr/share/locale -name gutenprint.mo)"
 
 override_dh_installdocs:
 	dh_installdocs -pescputil --link-doc=libgutenprint9

Reply to: