[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#980104: cups: reduce Build-Depends



Control: tags -1 +pending

Hello Helmut, 

First and foremost, thank you so much for your bootstrap work!

Le mercredi, 13 janvier 2021, 20.54:16 h CET Helmut Grohne a écrit :
> cups is involved in a number of dependency cycles relevant to
> architecture bootstrap. Instead of doing the hard work of looking into
> these cycles, I looked for easily droppable build dependencies and found
> some. Given that cups is reproducible, I attempted dropping individual
> dependencies via <!nocheck> and compared the resulting .debs with those
> of a regular build. It turns out that a lot of dependencies can be thus
> marked without affecting build results:
>  * ghostscript
>  * libavahi-compat-libdnssd-dev
>  * libfontconfig1-dev
>  * libfreetype6-dev
>  * libijs-dev
>  * libjpeg-dev
>  * libldap2-dev
>  * libpng-dev
>  * libtiff-dev
>  * poppler-utils
>  * sharutils
> 
> There are two possible mistakes being made here: For some dependencies,
> a fallback mechanism (e.g. vendored code copy) can be available. Thus it
> might be that not everything listed above should be tagged <!nocheck>.
> It also could be that some of these depenencies really are entirely
> unused. In that case, they should simply be dropped instead.

It seems you're right for all these!

I did some tests, including with Salsa CI, and I concur with your analysis; 
these are all likely outdated, now-superfluous Build-Dependencies.

I don't have any recollection of embedded vendoring, or code copies in CUPS, 
and would expect them to have been caught over the course of years.

Given this is all easily reversible, I'll just drop the Build-Depends as of 
now, and see where that leads.

> Beyond this, dh_apparmor is only used when cups-daemon is built. It can
> be dropped for indep-only builds.

About this too!

> Please consider applying and improving the attached patch.

Will do, thanks again!

-- 
    OdyX

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: