[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#992889: /usr/sbin/update-gsfontmap: overly complicated



Hi!

On Tue, Aug 24, 2021 at 07:30:31PM +0200, Jonas Smedegaard wrote:
> Quoting наб (2021-08-24 18:58:36)
> > The current approach that update-gsfontmap takes is very complicated, 
> > to no apparent end, since all it achieves is concatenating all the 
> > files; please consider the attached patch, which applies to every 
> > version since 7e78b19759ab1e47a3636ffd5c922c536e6cad37 (November of 
> > 2018)
> Your assesment is quite likely correct: that script hasn't been touched 
> since ancient times where more complex font registration scripts were 
> used in Debian (something called DeFoMa).
The DeFoMa page on the Debian Wiki and the corresponding manpage are an
interesting look down history lane (ancient history, I seem to've been
around 10 during the transition), thanks!

> Seems your patch is missing, however...
It's attachment 2, debbugs caught it:
	https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=992889;msg=5

I've included it in this mail, too, for good measure.

Best,
наб
diff --git a/debian/update-gsfontmap.orig b/debian/update-gsfontmap
index 5367ff6..c105363 100644
--- a/debian/update-gsfontmap.orig
+++ b/debian/update-gsfontmap
@@ -8,15 +8,7 @@ FONTMAP=/var/lib/ghostscript/fonts/Fontmap
 CIDFDIR=/etc/ghostscript/cidfmap.d/
 FONTMDIR=/etc/ghostscript/fontmap.d/
 
-rm -f "$CIDFMAP" "$FONTMAP"
-touch "$CIDFMAP" "$FONTMAP"
-
-for i in "$CIDFDIR"/*.conf; do
-    cat "$i" >> "$CIDFMAP"
-done 2>/dev/null
-
-for i in "$FONTMDIR"/*.conf; do
-    cat "$i" >> "$FONTMAP"
-done 2>/dev/null
+cat "$CIDFDIR"/*.conf  > "$CIDFMAP" 2>/dev/null
+cat "$FONTMDIR"/*.conf > "$FONTMAP" 2>/dev/null
 
 exit 0

Attachment: signature.asc
Description: PGP signature


Reply to: