[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#947185: marked as done (cups: Please omit cups server packages on Ubuntu/i386)

Your message dated Tue, 21 Jan 2020 10:48:13 +0100
with message-id <2011572.agcvC6tjD5@gyllingar>
and subject line Re: Bug#947185: cups: Please omit cups server packages on Ubuntu/i386
has caused the Debian Bug report #947185,
regarding cups: Please omit cups server packages on Ubuntu/i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
947185: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947185
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: cups
Version: 2.3.0-7
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64.  We are keeping cups on i386 because
libcups2 is needed by various 32-bit only binaries, but the cups server
packages built from this source have dependencies on other packages that are
not being kept as part of the compatibility library set
(cups-filters-core-drivers).

We would like to drop the cups and cups-core-drivers packages rather than
keeping them around in the Ubuntu archive and uninstallable.  Would you
please consider applying the attached patch, or something like it, to omit
building this binary package on Ubuntu?

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

diff -Nru cups-2.3.0/debian/rules cups-2.3.0/debian/rules
--- cups-2.3.0/debian/rules	2019-11-06 01:57:40.000000000 -0600
+++ cups-2.3.0/debian/rules	2019-12-22 11:10:53.000000000 -0600
@@ -7,6 +7,10 @@
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-pie
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
+ifeq ($(shell dpkg-vendor --is Ubuntu && echo yes) $(DEB_HOST_ARCH), yes i386)
+   skip_packages = -Ncups -Ncups-core-drivers
+endif
+
 # The build system uses only DSOFLAGS but not LDFLAGS to build some libraries.
 # Add LDFLAGS to enable (hardening) build flags.
 export DSOFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
@@ -247,3 +251,9 @@
 override_dh_installpam:
 	dh_installpam -pcups-daemon --name=cups
 	dh_installpam --remaining-packages
+
+override_dh_builddeb:
+	dh_builddeb ${skip_packages}
+
+override_dh_gencontrol:
+	dh_gencontrol ${skip_packages}

--- End Message ---
--- Begin Message --- 
Version: 2.3.1-1

Le dimanche, 22 décembre 2019, 18.22:47 h CET Steve Langasek a écrit :
> In Ubuntu, we are in the process of moving the i386 architecture to a
> compatibility-only layer on amd64.  We are keeping cups on i386 because
> libcups2 is needed by various 32-bit only binaries, but the cups server
> packages built from this source have dependencies on other packages that are
> not being kept as part of the compatibility library set
> (cups-filters-core-drivers).
> 
> We would like to drop the cups and cups-core-drivers packages rather than
> keeping them around in the Ubuntu archive and uninstallable.  Would you
> please consider applying the attached patch, or something like it, to omit
> building this binary package on Ubuntu?

I had actually included this in 2.3.1-1:

https://salsa.debian.org/printing-team/cups/commit/
2f23786ab0b7be4f646f380957c92971a343612d

I just totally forgot to add this in the changelog entry. I guess that's my 
punishment for not committing dch entries in my commits (but rely on gbp dch).

Thanks for the patch!
Cheers,
	OdyX

--- End Message ---
Reply to: