Bug#949315: cups-filters: driverless generates wrong InputSlots

[Martin Mares <mj@ucw.cz>]

Package: cups-filters
Version: 1.21.6-5
Severity: important

When I use "driverless" to generate a PPD for my Xerox B215 printer,
I get definition of InputSlot which does not work.

In particular, the printer reports that it supports media source "tray-1".
This is translated to "Tray-1" by driverless, so the PPD contains:

	*InputSlot Tray-1/Tray 1: ""

When I submit a print job, CUPS's IPP backend translates this to IPP
media source "tray--1", which is later rejected by the printer (the printer
replies by a malformed IPP message, but that's another story).

The problem lies in the mismatch between name mangling rules in
cups-filters-1.21.6/cupsfilters/ppdgenerator.c (the pwg_ppdize_name function)
and
cups-2.2.10/cups/ppd-cache.c (the pwg_unppdize_name function). It is hard
to tell which one is wrong as the name mangling rules seem arbitrary. However,
at least one of them needs fixing.

I checked cups-filters 1.26.2 and CUPS 2.3.1 and the name mangling functions
stay the same, so the problem is probably still present.


-- System Information:
Debian Release: 10.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8), LANGUAGE=en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages cups-filters depends on:
ii  bc                         1.07.1-2+b1
ii  cups-filters-core-drivers  1.21.6-5
ii  ghostscript                9.27~dfsg-2+deb10u3
ii  libc6                      2.28-10
ii  libcups2                   2.2.10-6+deb10u1
ii  libcupsfilters1            1.21.6-5
ii  libcupsimage2              2.2.10-6+deb10u1
ii  libfontconfig1             2.13.1-2
ii  libfontembed1              1.21.6-5
ii  libgcc1                    1:8.3.0-6
ii  libqpdf21                  8.4.0-2
ii  libstdc++6                 8.3.0-6
ii  poppler-utils              0.71.0-5

Versions of packages cups-filters recommends:
ii  colord             1.4.3-4
ii  liblouisutdml-bin  2.7.0-5+b1

Versions of packages cups-filters suggests:
ii  antiword                         0.37-14
pn  docx2txt                         <none>
ii  foomatic-db                      20181217-2
ii  imagemagick                      8:6.9.10.23+dfsg-2.1
ii  imagemagick-6.q16 [imagemagick]  8:6.9.10.23+dfsg-2.1

-- Configuration Files:
/etc/modules-load.d/cups-filters.conf changed [not included]

-- no debconf information