Bug#857500: cups-pdf: cups library should be set last

[Tiago Stürmer Daitx <tiago.daitx@canonical.com>]

Package: cups-pdf
Version: 3.0.1-2
Severity: normal
Tags: patch

Dear Maintainer,

Please consider applying the attached patch in order to move the cups
library as the last argument during the build. Libraries should be
declared later to adhere to standard POSIX-required behavior. This
early declaration currenly causes cups-pdf to FTBFS on Ubuntu Zesty.


Error from buildlog [1]:
x86_64-linux-gnu-gcc -lcups -o src/cups-pdf src/cups-pdf.c -Wdate-time
-D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -Wl,-z,relro  
/tmp/cc4NNYoz.o: In function `init':
./src/cups-pdf.c:359: undefined reference to `cupsBackendDeviceURI'
/tmp/cc4NNYoz.o: In function `read_config_ppd':
./src/cups-pdf.c:281: undefined reference to `ppdOpenFile'
./src/cups-pdf.c:286: undefined reference to `ppdMarkDefaults'
./src/cups-pdf.c:288: undefined reference to `ppdFirstOption'
./src/cups-pdf.c:291: undefined reference to `ppdNextOption'
./src/cups-pdf.c:293: undefined reference to `ppdClose'
/tmp/cc4NNYoz.o: In function `read_config_options':
./src/cups-pdf.c:304: undefined reference to `cupsParseOptions'
collect2: error: ld returned 1 exit status
debian/rules:20: recipe for target 'override_dh_auto_build-arch' failed
make[1]: *** [override_dh_auto_build-arch] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:26: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2


Thanks,
Tiago Daitx

[1] https://launchpad.net/ubuntu/+source/cups-pdf/3.0.1-2


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (400, 'xenial-proposed'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-34-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)