Bug#824483: libjbig2dec0: unused and unrelated Memento memory debugging code
Package: libjbig2dec0
Version: 0.13-1
Severity: normal
Tags: patch
Dear Maintainer,
I noticed that since ~0.12 libjbig2dec0.{a,so*} library includes
unused (and impossible to enable by library users) and unrelated Memento
memory debugging code.
Patch (against 0.13-1) attached.
-- System Information:
Debian Release: 8.4
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable'), (100,
'proposed-updates')
Architecture: i386 (x86_64)
Foreign Architectures: amd64
Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R (charmap=KOI8-R)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages libjbig2dec0 depends on:
ii libc6 2.19-18+deb8u4
ii libpng12-0 1.2.50-2+deb8u2
ii zlib1g 1:1.2.8.dfsg-2+b1
libjbig2dec0 recommends no packages.
libjbig2dec0 suggests no packages.
-- no debconf information
diff -Nru jbig2dec-0.13/debian/changelog jbig2dec-0.13/debian/changelog
--- jbig2dec-0.13/debian/changelog 2016-05-10 17:52:00.000000000 +0300
+++ jbig2dec-0.13/debian/changelog 2016-05-16 17:59:32.000000000 +0300
@@ -1,3 +1,10 @@
+jbig2dec (0.13-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Don't compile unrelated and unusable Memento memory debugging code.
+
+ -- Yuriy M. Kaminskiy <yumkam+debian@gmail.com> Mon, 16 May 2016 17:58:34 +0300
+
jbig2dec (0.13-1) unstable; urgency=medium
[ upstream ]
diff -Nru jbig2dec-0.13/debian/libjbig2dec0.symbols jbig2dec-0.13/debian/libjbig2dec0.symbols
--- jbig2dec-0.13/debian/libjbig2dec0.symbols 2016-05-10 17:40:23.000000000 +0300
+++ jbig2dec-0.13/debian/libjbig2dec0.symbols 2016-05-16 17:57:50.000000000 +0300
@@ -1,25 +1,4 @@
libjbig2dec.so.0 libjbig2dec0 #MINVER#
- Memento_breakAt@Base 0.12
- Memento_breakOnFree@Base 0.12
- Memento_breakOnRealloc@Base 0.12
- Memento_breakpoint@Base 0.12
- Memento_calloc@Base 0.12
- Memento_check@Base 0.12
- Memento_checkAllMemory@Base 0.12
- Memento_checkBlock@Base 0.12
- Memento_failAt@Base 0.12
- Memento_find@Base 0.12
- Memento_free@Base 0.12
- Memento_getBlockNum@Base 0.12
- Memento_label@Base 0.12
- Memento_listBlocks@Base 0.12
- Memento_listNewBlocks@Base 0.12
- Memento_malloc@Base 0.12
- Memento_paranoidAt@Base 0.12
- Memento_realloc@Base 0.12
- Memento_setMax@Base 0.12
- Memento_setParanoia@Base 0.12
- Memento_stats@Base 0.12
jbig2_alloc@Base 0.11
jbig2_arith_Qe@Base 0.11
jbig2_arith_decode@Base 0.11
diff -Nru jbig2dec-0.13/debian/patches/2001_disable_memento.patch jbig2dec-0.13/debian/patches/2001_disable_memento.patch
--- jbig2dec-0.13/debian/patches/2001_disable_memento.patch 1970-01-01 03:00:00.000000000 +0300
+++ jbig2dec-0.13/debian/patches/2001_disable_memento.patch 2016-05-16 17:58:29.000000000 +0300
@@ -0,0 +1,22 @@
+Index: jbig2dec-0.13/Makefile.am
+===================================================================
+--- jbig2dec-0.13.orig/Makefile.am
++++ jbig2dec-0.13/Makefile.am
+@@ -21,7 +21,7 @@ libjbig2dec_la_SOURCES = jbig2.c \
+ jbig2_arith.h jbig2_arith_iaid.h jbig2_arith_int.h \
+ jbig2_huffman.h jbig2_hufftab.h jbig2_mmr.h \
+ jbig2_generic.h jbig2_symbol_dict.h jbig2_text.h \
+- jbig2_metadata.c jbig2_metadata.h memento.c memento.h
++ jbig2_metadata.c jbig2_metadata.h
+
+ bin_PROGRAMS = jbig2dec
+ noinst_PROGRAMS = test_sha1 test_huffman test_arith
+@@ -35,6 +35,8 @@ dist_man_MANS = jbig2dec.1
+
+ EXTRA_DIST = test_jbig2dec.py msvc.mak LICENSE CHANGES
+
++EXTRA_SOURCES = memento.c memento.h
++
+ MAINTAINERCLEANFILES = config_types.h.in
+
+ TESTS = test_sha1 test_jbig2dec.py test_huffman test_arith
diff -Nru jbig2dec-0.13/debian/patches/series jbig2dec-0.13/debian/patches/series
--- jbig2dec-0.13/debian/patches/series 2016-05-10 15:13:31.000000000 +0300
+++ jbig2dec-0.13/debian/patches/series 2016-05-16 17:55:49.000000000 +0300
@@ -1,2 +1,3 @@
1001_ignore_python_test.patch
1004_extract_infile_from_autogen-sh.patch
+2001_disable_memento.patch
Reply to: