Bug#817883: hplip: FTBFS: 1 out of 1 hunk ignored -- saving rejects to file hp-laserjet_4000_series-ps.ppd.rej
Control: tag -1 pending
On Fri, Mar 11, 2016 at 08:53:14AM +0000, Chris Lamb wrote:
> Source: hplip
> Version: 3.16.2+repack0-6
> Severity: serious
> Justification: fails to build from source
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: ftbfs
> X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
>
> Dear Maintainer,
>
> hplip fails to build from source in unstable/amd64:
>
> [..]
>
> # Patch PPD file for the HP LaserJet 4000
> # See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742766
> # We cannot use the usual mechanisms for patches, as the PPD files get
> # shipped compressed by upstream
> ( cd /home/lamby/temp/cdt.20160311083550.TPPM2MDgZ5/hplip-3.16.2+repack0/debian/tmp/usr/share/ppd/hplip/HP/; \
> patch -p0 < /home/lamby/temp/cdt.20160311083550.TPPM2MDgZ5/hplip-3.16.2+repack0/debian/local/HP-LaserJet_4000-PostScript-PPD.patch; \
> rm *.orig \
> )
> patching file hp-laserjet_4000_series-ps.ppd
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 1 out of 1 hunk ignored -- saving rejects to file hp-laserjet_4000_series-ps.ppd.rej
> rm: cannot remove '*.orig': No such file or directory
> debian/rules:117: recipe for target 'override_dh_install-common' failed
> make[1]: *** [override_dh_install-common] Error 1
> make[1]: Leaving directory '/home/lamby/temp/cdt.20160311083550.TPPM2MDgZ5/hplip-3.16.2+repack0'
> debian/rules:51: recipe for target 'binary' failed
> make: *** [binary] Error 2
>
> [..]
>
> The full build log is attached.
The cause of this was a workaround to get it to build on buildds... - where it
builds fine now. But now building indep+arch builds in the same build is broken,
because I created override_dh_install-{arch,indep} and a common
override_dh_install-common on which they depend, but the -common part was run
twice, as dh invokes the rules file twice.
Anyway:
Fixed in git. I guess we'll wait the day before an upload, to see if anything else
pops up.
commit 3212f561d15d4c79dab67ccc5964b65a34a8a432
Author: Julian Andres Klode <jak@debian.org>
Date: Fri Mar 11 10:18:51 2016 +0100
Do not run install actions twice in indep+arch builds
The actions are not idempotent, especially the patch was
not. While that was dropped now, running the perl scripts
multiple times would cause -dNOINTERPOLATE to appear
multiple times, for example.
Work around this by only working on the binary-indep stuff
if it is built.
Closes: #817883
See http://anonscm.debian.org/cgit/printing/hplip.git/commit/?id=3212f561d15d4c79dab67ccc5964b65a34a8a432
for details
--
Debian Developer - deb.li/jak | jak-linux.org - free software dev
When replying, only quote what is necessary, and write each reply
directly below the part(s) it pertains to (`inline'). Thank you.
Reply to: