[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#740380: marked as done (logrotate warnings when running under systemd)



Your message dated Wed, 12 Mar 2014 13:18:52 +0000
with message-id <E1WNj3c-0001RF-8W@franck.debian.org>
and subject line Bug#740380: fixed in cups 1.7.1-8
has caused the Debian Bug report #740380,
regarding logrotate warnings when running under systemd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
740380: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740380
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: cups
Version: 1.7.1-7
Severity: normal

The logrotate script use a pre-start script to stop the cups service and
a post-rotate script to start cups again.
Under systemd this leads to a warning, since the socket and path are still
active and could lead to having the service activated on-demand.

# invoke-rc.d cups stop
Warning: Stopping cups.service, but it can still be activated by:
  cups.socket
  cups.path


My suggestion would be to use a single post-rotate script + restart.
As cups will still have the file descriptor open, you should use the
delaycompress option, so cups can continue to write to foo.1.log

My suggestion would be something like:

diff --git a/logrotate.d/cups-daemon b/logrotate.d/cups-daemon
index d96e11d..09b7145 100644
--- a/logrotate.d/cups-daemon
+++ b/logrotate.d/cups-daemon
@@ -3,20 +3,10 @@
        missingok
        rotate 7
        sharedscripts
-       prerotate
-               if [ -e /var/run/cups/cupsd.pid ]; then
-                       invoke-rc.d --quiet cups stop > /dev/null
-                       touch /var/run/cups/cupsd.stopped
-               fi
-       endscript
        postrotate
-               if [ -e /var/run/cups/cupsd.stopped ]; then
-                       rm /var/run/cups/cupsd.stopped
-                       invoke-rc.d --quiet cups start > /dev/null
-                       sleep 10
-               fi
+               invoke-rc.d --quiet cups restart > /dev/null
        endscript
-       compress
+       delaycompress
        notifempty
        create
 }


Since the "sleep 10" didn't make any sense to me, I removed that as well.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cups depends on:
ii  cups-client            1.7.1-7
ii  cups-common            1.7.1-7
ii  cups-core-drivers      1.7.1-7
ii  cups-daemon            1.7.1-7
ii  cups-filters           1.0.46-1
ii  cups-ppdc              1.7.1-7
ii  cups-server-common     1.7.1-7
ii  debconf [debconf-2.0]  1.5.52
ii  ghostscript            9.05~dfsg-8+b1
ii  libavahi-client3       0.6.31-4
ii  libavahi-common3       0.6.31-4
ii  libc-bin               2.18-3
ii  libc6                  2.18-3
ii  libcups2               1.7.1-7
ii  libcupscgi1            1.7.1-7
ii  libcupsimage2          1.7.1-7
ii  libcupsmime1           1.7.1-7
ii  libcupsppdc1           1.7.1-7
ii  libgcc1                1:4.8.2-16
ii  libstdc++6             4.8.2-16
ii  libusb-1.0-0           2:1.0.17-1+b1
ii  lsb-base               4.1+Debian12
ii  poppler-utils          0.22.5-4
ii  procps                 1:3.3.9-4

Versions of packages cups recommends:
ii  avahi-daemon                     0.6.31-4
ii  colord                           1.0.6-1
ii  cups-filters [ghostscript-cups]  1.0.46-1
ii  printer-driver-gutenprint        5.2.9-1

Versions of packages cups suggests:
ii  cups-bsd               1.7.1-7
pn  cups-pdf               <none>
ii  foomatic-db            20140106-1
pn  hplip                  <none>
pn  printer-driver-hpcups  <none>
ii  smbclient              2:4.1.5+dfsg-1
ii  udev                   204-7

-- debconf information excluded

--- End Message ---
--- Begin Message ---
Source: cups
Source-Version: 1.7.1-8

We believe that the bug you reported is fixed in the latest version of
cups, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 740380@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <odyx@debian.org> (supplier of updated cups package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 12 Mar 2014 12:03:14 +0100
Source: cups
Binary: libcups2 libcupsimage2 libcupscgi1 libcupsmime1 libcupsppdc1 cups cups-core-drivers cups-daemon cups-client libcups2-dev libcupsimage2-dev libcupscgi1-dev libcupsmime1-dev libcupsppdc1-dev cups-bsd cups-common cups-server-common cups-ppdc cups-dbg
Architecture: source amd64 all
Version: 1.7.1-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Team <debian-printing@lists.debian.org>
Changed-By: Didier Raboud <odyx@debian.org>
Description: 
 cups       - Common UNIX Printing System(tm) - PPD/driver support, web interfa
 cups-bsd   - Common UNIX Printing System(tm) - BSD commands
 cups-client - Common UNIX Printing System(tm) - client programs (SysV)
 cups-common - Common UNIX Printing System(tm) - common files
 cups-core-drivers - Common UNIX Printing System(tm) - PPD-less printing
 cups-daemon - Common UNIX Printing System(tm) - daemon
 cups-dbg   - Common UNIX Printing System(tm) - debugging symbols
 cups-ppdc  - Common UNIX Printing System(tm) - PPD manipulation utilities
 cups-server-common - Common UNIX Printing System(tm) - server common files
 libcups2   - Common UNIX Printing System(tm) - Core library
 libcups2-dev - Common UNIX Printing System(tm) - Development files CUPS library
 libcupscgi1 - Common UNIX Printing System(tm) - CGI library
 libcupscgi1-dev - Common UNIX Printing System(tm) - Development files for CGI libra
 libcupsimage2 - Common UNIX Printing System(tm) - Raster image library
 libcupsimage2-dev - Common UNIX Printing System(tm) - Development files CUPS image li
 libcupsmime1 - Common UNIX Printing System(tm) - MIME library
 libcupsmime1-dev - Common UNIX Printing System(tm) - Development files MIME library
 libcupsppdc1 - Common UNIX Printing System(tm) - PPD manipulation library
 libcupsppdc1-dev - Common UNIX Printing System(tm) - Development files PPD library
Closes: 689084 740380 740382
Changes: 
 cups (1.7.1-8) unstable; urgency=medium
 .
   [ Helge Kreutzmann ]
   * Update German man page (1522t1f)
 .
   [ Didier Raboud ]
   * Make libcups2-dev Multi-Arch: same (Closes: #689084)
   * Replace the cupsd-support-avahi-daemon-restarting patch with the latest
     upstream iteration (STR: #4373)
   * Add patch to let CUPS write its own systemd sockets configuration when
     configured through the webinterface; document this new behaviour in
     cups-daemon.NEWS and README.Debian (Closes: #740382)
   * Stop making lppasswd setuid root as it is only needed in specific cases
     - Add patch to lppasswd manpage to document how dpkg-statoverride should be
       used
     - Update translations
   * Move the repository from pkg-cups to printing; update the VCS-* fields
     accordingly
 .
   [ Ansgar Burchardt ]
   * systemd socket activation support: add cups.socket in Requires of
     cups.service to ensure that the service is stopped before the socket is
     attempted to be started. Also add Documentation references in cups.service
 .
   [ Till Kamppeter ]
   * Fix crash bug in the cupsEnumDests() function (STR #4380).
   * Import upstream patch to fix race condition in cupsDoIORequest()
     (STR: #4386)
   * Import upstream patch to fix a missing NULL check for input parameters in
     cupsdGetPrivateAttrs() from scheduler/policy.c (STR: #4378)
   * Import upstream fix to let cupsEnumDests() fill in is_default field
     (STR: #4332)
 .
   [ Michael Biebl ]
   * Fix the logrotate script to use delaycompress instead of stopping and
     restarting cups, which spits out warnings under systemd (Closes: #740380)
Checksums-Sha1: 
 4778cee11be4596733bc7026c487d80e9337ff88 3317 cups_1.7.1-8.dsc
 c8a256d780367caa59cc1cef922b6cb3394669fa 297220 cups_1.7.1-8.debian.tar.xz
 6dbf074f6192b2782ed10444eec9a2201b6df242 274264 libcups2_1.7.1-8_amd64.deb
 124ebfe45dbd71c7e7263ccb66229efb791939e8 110600 libcupsimage2_1.7.1-8_amd64.deb
 fa8713987645558803a363988b679c7cb6162978 121830 libcupscgi1_1.7.1-8_amd64.deb
 6aa6f18029d4bf2716ab123a004c503c7a0844f7 107548 libcupsmime1_1.7.1-8_amd64.deb
 e3891c9bcf0dd709afb685dbbe4628811831e8ff 139934 libcupsppdc1_1.7.1-8_amd64.deb
 8d0302e9d8124bdcef2b7d304ca167c05d4ac8df 282456 cups_1.7.1-8_amd64.deb
 648ae14be681704143ab50ba4175ef1f1a83cf51 120714 cups-core-drivers_1.7.1-8_amd64.deb
 fe2540636ebf3f46fb9fae66e417ed9ba0869493 361830 cups-daemon_1.7.1-8_amd64.deb
 4585cf838747e1d0a58924099204a18abff08821 290238 cups-client_1.7.1-8_amd64.deb
 c440d953fe30008fff5994ca7d56ad66706fc904 311706 libcups2-dev_1.7.1-8_amd64.deb
 a4010b64b69a5e745bcf7db7abf6b1bebcd719b6 18038 libcupsimage2-dev_1.7.1-8_amd64.deb
 ea547d13eae4071275f93070817e0fccf8b26eb2 124214 libcupscgi1-dev_1.7.1-8_amd64.deb
 7f27399288d7150cc834ced2fe80d3a0f3bd90cb 108162 libcupsmime1-dev_1.7.1-8_amd64.deb
 a37dc746867425b226f1b5a5c44b55ac9d65512f 144496 libcupsppdc1-dev_1.7.1-8_amd64.deb
 7d1a803d1b8603622b6aeab827a5944ab10be61b 35026 cups-bsd_1.7.1-8_amd64.deb
 903667341fc711ed97c5fed36873185c8317ca70 239372 cups-common_1.7.1-8_all.deb
 b175f0ba5d64241260ae03bbcc5ea8a633d8ce04 595424 cups-server-common_1.7.1-8_all.deb
 571e979a05e12af76ad78a60c564683455ab2a2d 120764 cups-ppdc_1.7.1-8_amd64.deb
 ec0e4742a6cd3dad9a65cad70c5594c59d044187 2120588 cups-dbg_1.7.1-8_amd64.deb
Checksums-Sha256: 
 576064ac55f18f5be7b3b6835456fe87ef6fe210246dd811c7b0c3bc5e9c486e 3317 cups_1.7.1-8.dsc
 2ecc350160da7f85b9ec67c2e867a7a2fa62710d5f3a4a6ebf93a6df699469b4 297220 cups_1.7.1-8.debian.tar.xz
 c5850151333d36351997f3091841a0f837adaba31d29ba07dfe4875572aa1741 274264 libcups2_1.7.1-8_amd64.deb
 bba342f15475794127190a81ae5eaa0277baca51b4e50aa3a242f4f7b3f7f707 110600 libcupsimage2_1.7.1-8_amd64.deb
 39554f17a1decfb8e67a0c574cfb2f6af75b34ec7b968bef3df1c2164c29de58 121830 libcupscgi1_1.7.1-8_amd64.deb
 9199a80aa32fb0dc160887fa0964e15e76f81825fec360660f0420ca5ea64e99 107548 libcupsmime1_1.7.1-8_amd64.deb
 c5032fb6fb6d37fde5623fcf799278de6a48e2aa3de8e6032cf7a9b01fe4835e 139934 libcupsppdc1_1.7.1-8_amd64.deb
 abc51fdfb515d4b8a02694502fd54bff12c2114bcab9654d5e04902dbb03fa9e 282456 cups_1.7.1-8_amd64.deb
 396f356c4e516a154a28ae2403c4aeb1fbc0a2dd7ec2c6664606cd45354956c1 120714 cups-core-drivers_1.7.1-8_amd64.deb
 736053fd8949237559310134da57d48d263a4b81287b2e7cfc7b10bfdc66d1f1 361830 cups-daemon_1.7.1-8_amd64.deb
 97d79419ac9809402c58799d2b658ec0220b0f79fbc4244bcb3562a9cab5aa52 290238 cups-client_1.7.1-8_amd64.deb
 6a30e47d71a7ed682277f1ffd2caa742821a9e0a87f5cb797d6a14f214663a52 311706 libcups2-dev_1.7.1-8_amd64.deb
 3580301822462397ebc0420eca168f164b2ab65e68277cfd01f78836637d63a4 18038 libcupsimage2-dev_1.7.1-8_amd64.deb
 dbb6fd7fa580ebe39cc5e415266d561ec020769660d7475309f0c2c1a5a8ddb2 124214 libcupscgi1-dev_1.7.1-8_amd64.deb
 d588c595159feae7c77e179876ad360164c78dd3b0e4a4a11f1068092484ca8f 108162 libcupsmime1-dev_1.7.1-8_amd64.deb
 4b96377fc64bff4df37872f426abb3818881a16da31dd2a03b4b9f215b411daf 144496 libcupsppdc1-dev_1.7.1-8_amd64.deb
 f192b73a5534ce19fb0fa07031f39a81a751efa3f95ecb3e20cf55c189134b7b 35026 cups-bsd_1.7.1-8_amd64.deb
 08a2daaa6761b41efbd14940c7f3d57f800c7f31ab3bea405e5a9c0ae5536c0d 239372 cups-common_1.7.1-8_all.deb
 cfa7d566c6f08701628c306395153b91b0680694216c693b8c58770a645eaf7b 595424 cups-server-common_1.7.1-8_all.deb
 4d61b9cc4133c5611ba3cf50384b5e0dd17dfd7fb0e846e1148f70b6f855849d 120764 cups-ppdc_1.7.1-8_amd64.deb
 3838dc895387f8a53fde4a6117f1055c150a50c9351eb8c0e0fdc323d6a601f5 2120588 cups-dbg_1.7.1-8_amd64.deb
Files: 
 6271dd7e2965bb1b65de0cd9158912ff 3317 net optional cups_1.7.1-8.dsc
 98228c41c92dfe4d84e46d900f144978 297220 net optional cups_1.7.1-8.debian.tar.xz
 ab30968a28ec7ee19e88c9b38c0f9306 274264 libs optional libcups2_1.7.1-8_amd64.deb
 45ce3a8497ba04b2790cd1dcc2194db5 110600 libs optional libcupsimage2_1.7.1-8_amd64.deb
 0f7029bb570961d1c71e8460a82c8615 121830 libs optional libcupscgi1_1.7.1-8_amd64.deb
 1b8c611d13e373d2bba9e7eb142f381f 107548 libs optional libcupsmime1_1.7.1-8_amd64.deb
 16dc5e122a9898b3830428c7d24586b5 139934 libs optional libcupsppdc1_1.7.1-8_amd64.deb
 80137e53db8f3f265e94dc22ab7daf73 282456 net optional cups_1.7.1-8_amd64.deb
 04505c3575fcb7a35b1ae547e1557dce 120714 net optional cups-core-drivers_1.7.1-8_amd64.deb
 c15b09c314dee07e6cf6e03fd63040cd 361830 net optional cups-daemon_1.7.1-8_amd64.deb
 b280b47c29fe6f219f817ae916059427 290238 net optional cups-client_1.7.1-8_amd64.deb
 427849dc862319c63a8971cf5a82e209 311706 libdevel optional libcups2-dev_1.7.1-8_amd64.deb
 ba997443fe86301fe35eaf919c86a540 18038 libdevel optional libcupsimage2-dev_1.7.1-8_amd64.deb
 ae80d9bc2bf7d7227c934f2676a582d1 124214 libdevel optional libcupscgi1-dev_1.7.1-8_amd64.deb
 a8b36166b65b33f86ee19c2c5fe11414 108162 libdevel optional libcupsmime1-dev_1.7.1-8_amd64.deb
 4952609a1abc6f53eaf4b88d5d35e317 144496 libdevel optional libcupsppdc1-dev_1.7.1-8_amd64.deb
 c6141842f8a6d33cf414b1d9b703c3d9 35026 net extra cups-bsd_1.7.1-8_amd64.deb
 a3bf1f6a341522318c6c56780821e244 239372 net optional cups-common_1.7.1-8_all.deb
 9ae9c32f4331d3bbd20133d0668958f4 595424 net optional cups-server-common_1.7.1-8_all.deb
 1c163fd8331b805d83f0b2acf6849730 120764 utils optional cups-ppdc_1.7.1-8_amd64.deb
 e9a70f5709866322dcac4cf57391f8ea 2120588 debug extra cups-dbg_1.7.1-8_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQGcBAEBCAAGBQJTIFpAAAoJEIvPpx7KFjRVjFwL/jYk0mznCZYx0KmFujeQzv/A
Xt+7gOsmtxR2/TjoqZiocuYVAFWVF/g4AvpypmcV/04H/Z7nygjzH8QcuBsAkJev
x5Tj7tLAK6/PB/0GY1bwMaX92Lws+XHNnXVBjopcRiIo/bLpxL+t1EsG1xPOzoVP
66Wc9PTaTlaF0G++rFyxC+fynzrF37KBZDykwXX1MSYdjihyWk3Arc1gfeCopm5t
mCJaU1HMrDAH911klY5Iy50I6aS3n3QSI7HoDdSONin4+yEZgEekFLzmd3MmOXw/
Wroq1T7qVgdsw7U4ltVQJUq41BfI5UrQ21OdBU+qX8YSkj0Ep4Tdrbo+vm+cVjbF
rrYuhVgGuBGIBno0QVbkZikK/G7m1Eorj/6+mmSokcWqwV7/wepk7q+VSeEhQ+EB
bxebwJD1MCHHEcm6hQaDmOxgjkLiDR57BRhRlSsD2fWLW99PXk9Pki0Xr5NlGWHv
yu6rzmLmTkFG7GjRRUYwzazsfj4s6hKtxuoe3NvBxg==
=V8oY
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: