[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#674520: marked as done (cups ignores "Allow From @IF(eth0)" entries in /etc/cups/cupsd.conf)



Your message dated Thu, 09 Jan 2014 16:48:54 +0000
with message-id <E1W1Ims-0005jp-IN@franck.debian.org>
and subject line Bug#674520: fixed in cups 1.7.1-1
has caused the Debian Bug report #674520,
regarding cups ignores "Allow From @IF(eth0)" entries in /etc/cups/cupsd.conf
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
674520: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674520
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: cups
Version: 1.4.4-7+squeeze1
Severity: normal
Tags: squeeze patch

If /etc/cups/cupsd.conf is configured with something like this

<Location />
Order Deny,Allow
Deny From All
Allow From @IF(eth0)
Allow From @IF(eth2)
</Location>

the "Allow From @IF(...)" lines will be ignored.

After some searching through the cups source code, I found that in
scheduler/auth.c the "cupsdNetIFUpdate()" function is only called if "Allow
>From @LOCAL" is used. In the "Allow From @IF(...)" case the cupsdNetIFUpdate()
function is not called at all. So the "NetIFList" structure is not
filled/updated and the loop "for (iface = ...." will do nothing at all.

The simplest fix, which worked for me, was to add "cupsdNetIFUpdate();" before
this loop.

I build a new package with this fix and can confirm, that the problem is gone.




-- System Information:
Debian Release: 6.0.5
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-core2 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages cups depends on:
ii  adduser             3.112+nmu2           add and remove users and groups
ii  bc                  1.06.95-2            The GNU bc arbitrary precision cal
ii  cups-client         1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  cups-common         1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  cups-ppdc           1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  debconf [debconf-2. 1.5.36.1             Debian configuration management sy
ii  ghostscript         8.71~dfsg2-9         The GPL Ghostscript PostScript/PDF
ii  libavahi-client3    0.6.27-2+squeeze1    Avahi client library
ii  libavahi-common3    0.6.27-2+squeeze1    Avahi common library
ii  libc6               2.11.3-3             Embedded GNU C Library: Shared lib
ii  libcups2            1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  libcupscgi1         1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  libcupsdriver1      1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  libcupsimage2       1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  libcupsmime1        1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  libcupsppdc1        1.4.4-7+squeeze1     Common UNIX Printing System(tm) - 
ii  libdbus-1-3         1.2.24-4+squeeze1    simple interprocess messaging syst
ii  libgcc1             1:4.4.5-8            GCC support library
ii  libgnutls26         2.8.6-1+squeeze2     the GNU TLS library - runtime libr
ii  libgssapi-krb5-2    1.8.3+dfsg-4squeeze5 MIT Kerberos runtime libraries - k
ii  libijs-0.35         0.35-7               IJS raster image transport protoco
ii  libkrb5-3           1.8.3+dfsg-4squeeze5 MIT Kerberos runtime libraries
ii  libldap-2.4-2       2.4.23-7.2           OpenLDAP libraries
ii  libpam0g            1.1.1-6.1+squeeze1   Pluggable Authentication Modules l
ii  libpaper1           1.1.24               library for handling paper charact
ii  libpoppler5         0.12.4-1.2           PDF rendering library
ii  libslp1             1.2.1-7.8            OpenSLP libraries
ii  libstdc++6          4.4.5-8              The GNU Standard C++ Library v3
ii  libusb-0.1-4        2:0.1.12-16          userspace USB programming library
ii  lsb-base            3.2-23.2squeeze1     Linux Standard Base 3.2 init scrip
ii  poppler-utils       0.12.4-1.2           PDF utilitites (based on libpopple
ii  procps              1:3.2.8-9squeeze1    /proc file system utilities
ii  ssl-cert            1.0.28               simple debconf wrapper for OpenSSL
ii  ttf-freefont        20090104-7           Freefont Serif, Sans and Mono True
ii  zlib1g              1:1.2.3.4.dfsg-3     compression library - runtime

Versions of packages cups recommends:
ii  cups-driver-gutenprint  5.2.6-1          printer drivers for CUPS
ii  foomatic-filters        4.0.5-6+squeeze2 OpenPrinting printer support - fil
ii  ghostscript-cups        8.71~dfsg2-9     The GPL Ghostscript PostScript/PDF

Versions of packages cups suggests:
ii  cups-bsd          1.4.4-7+squeeze1       Common UNIX Printing System(tm) - 
ii  cups-pdf          2.5.0-16               PDF printer for CUPS
ii  foomatic-db       20100630-1             OpenPrinting printer support - dat
ii  hplip             3.10.6-2+squeeze1      HP Linux Printing and Imaging Syst
ii  smbclient         2:3.5.6~dfsg-3squeeze8 command-line SMB/CIFS clients for 
ii  udev              164-3                  /dev/ and hotplug management daemo
pn  xpdf-korean | xpd <none>                 (no description available)

-- Configuration Files:
/etc/cups/cupsd.conf [Errno 13] Keine Berechtigung: u'/etc/cups/cupsd.conf'

-- debconf information excluded
--- scheduler/auth.c.orig	2012-05-25 09:18:11.118294891 +0200
+++ scheduler/auth.c	2012-05-25 09:19:17.262796432 +0200
@@ -1278,6 +1278,8 @@
 	    * Check the named interface...
 	    */
 
+            cupsdNetIFUpdate();
+
 	    for (iface = (cupsd_netif_t *)cupsArrayFirst(NetIFList);
 	         iface;
 		 iface = (cupsd_netif_t *)cupsArrayNext(NetIFList))

--- End Message ---
--- Begin Message ---
Source: cups
Source-Version: 1.7.1-1

We believe that the bug you reported is fixed in the latest version of
cups, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 674520@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <odyx@debian.org> (supplier of updated cups package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 09 Jan 2014 16:54:26 +0100
Source: cups
Binary: libcups2 libcupsimage2 libcupscgi1 libcupsmime1 libcupsppdc1 cups cups-daemon cups-client libcups2-dev libcupsimage2-dev libcupscgi1-dev libcupsmime1-dev libcupsppdc1-dev cups-bsd cups-common cups-server-common cups-ppdc cups-dbg
Architecture: source amd64 all
Version: 1.7.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Team <debian-printing@lists.debian.org>
Changed-By: Didier Raboud <odyx@debian.org>
Description: 
 cups       - Common UNIX Printing System(tm) - server
 cups-bsd   - Common UNIX Printing System(tm) - BSD commands
 cups-client - Common UNIX Printing System(tm) - client programs (SysV)
 cups-common - Common UNIX Printing System(tm) - common files
 cups-daemon - Common UNIX Printing System(tm) - daemon
 cups-dbg   - Common UNIX Printing System(tm) - debugging symbols
 cups-ppdc  - Common UNIX Printing System(tm) - PPD manipulation utilities
 cups-server-common - Common UNIX Printing System(tm) - server common files
 libcups2   - Common UNIX Printing System(tm) - Core library
 libcups2-dev - Common UNIX Printing System(tm) - Development files CUPS library
 libcupscgi1 - Common UNIX Printing System(tm) - CGI library
 libcupscgi1-dev - Common UNIX Printing System(tm) - Development files for CGI libra
 libcupsimage2 - Common UNIX Printing System(tm) - Raster image library
 libcupsimage2-dev - Common UNIX Printing System(tm) - Development files CUPS image li
 libcupsmime1 - Common UNIX Printing System(tm) - MIME library
 libcupsmime1-dev - Common UNIX Printing System(tm) - Development files MIME library
 libcupsppdc1 - Common UNIX Printing System(tm) - PPD manipulation library
 libcupsppdc1-dev - Common UNIX Printing System(tm) - Development files PPD library
Closes: 674520 714492 734670
Changes: 
 cups (1.7.1-1) unstable; urgency=medium
 .
   * New 1.7.0 upstream release
    - Security: the lppasswd program incorrectly used settings from
      ~/.cups/client.conf (STR #4319)
    - Some gzip'd PPD files could not be used
    - Cleaned up some job logging in the scheduler
    - ATTR messages could cause string pool memory corruption in the
      scheduler
    - Printing to a raw queue could result in corrupt output due to
      opportunistic compression
    - The "make check" test suite did not work on Linux without the
      cups-filters package installed (That's not fully fixed yet)
    - The libusb-based USB backend incorrectly used write timeouts
    - Using "@IF(name)" in an Allow or Deny rule did not wor
      (STR #4328, Closes: #674520)
    - The D-BUS notifier did not remove its lockfile (STR #4314)
 .
   [ Didier Raboud ]
   * Link against OpenSSL instead of GnuTLS; mark two GnuTLS-specific
     symbols in libcups2 as optional (Closes: #714492)
   * Refresh 13 patches for 1.7.1
   * Drop patches obsoleted by 1.7.1:
     - avoid-sign-extending-CRCs-for-gz-decompression
     - avoid_stale_lockfile_in_dbus_notifier
     - cups-dbus-utf8
     - fix-job-history-logging
     - fix-stringpool-corruption
     - prevent-USB-timeouts-causing-incorrect-print-output
   * Refresh the testsuite patches
   * Rewrite tests-use-cupsfilters patch to have the whole test-suite
     pass
 .
   [ wookey ]
   * Honour DEB_BUILD_OPTIONS=nocheck (Closes: #734670)
Checksums-Sha1: 
 5aa2ca0dd61a4887e59e95cd011a6f0366c5bc61 3168 cups_1.7.1-1.dsc
 309945aa10b5a93078a6d2bc0a33b3dd711bff18 8738002 cups_1.7.1.orig.tar.bz2
 0908d984e2a434cbd6694964eb662497889bcb38 437011 cups_1.7.1-1.debian.tar.gz
 84742117ee522cf5c4f8f0d92e7c70116e9afed2 269846 libcups2_1.7.1-1_amd64.deb
 29f2eb03e520eeba17081fe8ddf0da47b64a3bc0 108140 libcupsimage2_1.7.1-1_amd64.deb
 4a39e694a541a47b1ee468b1f52a1d93eb83622a 119036 libcupscgi1_1.7.1-1_amd64.deb
 b0fa566ed325066d74677906779d6062b5d2e8df 105012 libcupsmime1_1.7.1-1_amd64.deb
 a6cdd75f4504145336c1392e9daeee6b980093a1 137010 libcupsppdc1_1.7.1-1_amd64.deb
 eb8f44dde46cc6445ed5b8edf9b3d012569a41bf 295598 cups_1.7.1-1_amd64.deb
 221f905824d64424f568f125efdaef42233a7ff6 355322 cups-daemon_1.7.1-1_amd64.deb
 c9bb4df08eb0ee4bf6a980af146453c626c62c91 287710 cups-client_1.7.1-1_amd64.deb
 e4cff358e697ebde807ed93600347fb892328bfc 308854 libcups2-dev_1.7.1-1_amd64.deb
 3373c4a9ae43457dcc9c99bf666f748c7d1084f9 18124 libcupsimage2-dev_1.7.1-1_amd64.deb
 2007d6fb865c79c2962cc4ef33850e34acc9a806 121508 libcupscgi1-dev_1.7.1-1_amd64.deb
 40d084d61a144aa4cdaab847991cc5b932019f75 105680 libcupsmime1-dev_1.7.1-1_amd64.deb
 a5ad35ad2254ea0e8300faaa75b38cc7846b3add 142156 libcupsppdc1-dev_1.7.1-1_amd64.deb
 e4de2a887dc4c6d66babd52906dc13b701d3664c 26570 cups-bsd_1.7.1-1_amd64.deb
 0734528bac1e015422b87dbafdda1d20f9a5192a 236780 cups-common_1.7.1-1_all.deb
 c73b8078dd7e721d73ad40c399c9c16201c193ca 591082 cups-server-common_1.7.1-1_all.deb
 16e1f53d89c32968a8c63f4eba51371d5d4fde2f 118332 cups-ppdc_1.7.1-1_amd64.deb
 c01e54b65ecdb1cc5c572873ce6c226a1fb7f31d 2800688 cups-dbg_1.7.1-1_amd64.deb
Checksums-Sha256: 
 15a22a2c3dd63071498ccd388e27cb5c84ff319cb892c5e88b7cb88a13e0b52c 3168 cups_1.7.1-1.dsc
 f52bec893d9daf92b6029be79c07e6c516b4c85ffae3e6e01885cc85e9081681 8738002 cups_1.7.1.orig.tar.bz2
 952cc8cdf658cef083991fd150d27131c940797aea530c52bb0d58227d30d88f 437011 cups_1.7.1-1.debian.tar.gz
 49ce331bf44ee76502d653f46bfa30aa1e1db975a6e07cf04838e69f7ab62657 269846 libcups2_1.7.1-1_amd64.deb
 0b26c950c2de2ce69fa2f2f103992aa1926c2a98f5b7ff94bc1cb09cadd9e758 108140 libcupsimage2_1.7.1-1_amd64.deb
 b180aa2ae01d12e66169e7532c28b682c37ab8f54cfaa525ef5cfd09ed4ed7db 119036 libcupscgi1_1.7.1-1_amd64.deb
 f77492cf562656b570e9ec6e8330df82f6d43338571ec9a14a51b13f3717313f 105012 libcupsmime1_1.7.1-1_amd64.deb
 14b1cccaca65da688c856c89f8bd2b324658264669e2dce849123b1762cad77b 137010 libcupsppdc1_1.7.1-1_amd64.deb
 7325490c77820ecdbeffabaa9ca93925cb42efb64dfa1bc430b64f08090b92de 295598 cups_1.7.1-1_amd64.deb
 d64e4add8fa8f26debf8806c56f476ddfd2c1058e1d841a1328a51be1a233caf 355322 cups-daemon_1.7.1-1_amd64.deb
 ba5d9250f940bd019e209cb9f93de111be2b54e785de3f6a51dfcfa4a9630d34 287710 cups-client_1.7.1-1_amd64.deb
 13c5517984f2b7458b544d063c9119b32ff2236c96e5d7e241663b32275fd460 308854 libcups2-dev_1.7.1-1_amd64.deb
 745ddb606567c42cd3e68617c88da366f649b46d81428789cbf1dcb2b701114f 18124 libcupsimage2-dev_1.7.1-1_amd64.deb
 378fa42330d5a86a63b358433cad213a508212bf705a0d5569ad97576c196590 121508 libcupscgi1-dev_1.7.1-1_amd64.deb
 65ccbc5157df5d8c13d071f59740f80857a5d6e830af3fa95da68dfc650aab96 105680 libcupsmime1-dev_1.7.1-1_amd64.deb
 5fa133ebcb7e8a62a9499e68c1a0bb7d85213638b8b40b072ab0fb2355f3f4af 142156 libcupsppdc1-dev_1.7.1-1_amd64.deb
 da810a9306543723f97fbc1224b8d81e6785b74c1c3194a38661ae6d28035d56 26570 cups-bsd_1.7.1-1_amd64.deb
 eb6dbae6a11e4e173f205c4e7eaa4299ff26ed1236606dd5eb4e70673a939855 236780 cups-common_1.7.1-1_all.deb
 4d534b6cadae53305bd40eafe480c508c378347600281ac06258ed405ac1788c 591082 cups-server-common_1.7.1-1_all.deb
 ecc2de48b4a11f2ccb4823668a3a32e7261bfa77314510767aa3841aa824e567 118332 cups-ppdc_1.7.1-1_amd64.deb
 8aee7bce88249ba406b0236a5699e83ef33b4d8daf7e15394741b17130db0636 2800688 cups-dbg_1.7.1-1_amd64.deb
Files: 
 16a67ca799c3261f1215fa9ef3bc2e5f 3168 net optional cups_1.7.1-1.dsc
 55277c40fd4b7183dc3671d39c5c42b7 8738002 net optional cups_1.7.1.orig.tar.bz2
 0df42ff1f86d2c39cb9f3904f0e6e3ce 437011 net optional cups_1.7.1-1.debian.tar.gz
 c7b547d03692de3206df091eaf6d8fb1 269846 libs optional libcups2_1.7.1-1_amd64.deb
 83d98543e9d5f755e20fcc6979a6e7c3 108140 libs optional libcupsimage2_1.7.1-1_amd64.deb
 f405bd14ab2fcd60c96c9188cda30a01 119036 libs optional libcupscgi1_1.7.1-1_amd64.deb
 dd41c340787ef0e65235aa1a77642d58 105012 libs optional libcupsmime1_1.7.1-1_amd64.deb
 1cad9a6858353e5be4a9b4c1f73142a6 137010 libs optional libcupsppdc1_1.7.1-1_amd64.deb
 4048bc3ad8b33692cfbb70a76f5adc40 295598 net optional cups_1.7.1-1_amd64.deb
 36d5023feb91236be649f6f5601455da 355322 net optional cups-daemon_1.7.1-1_amd64.deb
 cd7a5d7d29cd10b1708db314a0b832b5 287710 net optional cups-client_1.7.1-1_amd64.deb
 1a11536aeafa0402a33ebe87242f30f4 308854 libdevel optional libcups2-dev_1.7.1-1_amd64.deb
 94ba1c1a59435cbe8a77e43637ccb14e 18124 libdevel optional libcupsimage2-dev_1.7.1-1_amd64.deb
 4da1a2367c8a3c96222dc2a72ae70b5b 121508 libdevel optional libcupscgi1-dev_1.7.1-1_amd64.deb
 92c9870d1abd6cfc95eb2c5f5256d5da 105680 libdevel optional libcupsmime1-dev_1.7.1-1_amd64.deb
 52fbc6b9b60c15ee865f273b0bbf136d 142156 libdevel optional libcupsppdc1-dev_1.7.1-1_amd64.deb
 6e8926cc546282a6a7687990749f07d1 26570 net extra cups-bsd_1.7.1-1_amd64.deb
 0f179c8db594e5c9149b8a616a021bfc 236780 net optional cups-common_1.7.1-1_all.deb
 17e9521b688a6a49d9471341d2f66538 591082 net optional cups-server-common_1.7.1-1_all.deb
 874504c51ab4d6d1b792de160d32f23c 118332 utils optional cups-ppdc_1.7.1-1_amd64.deb
 9aae8a5c13cd60cfefeb95461f94a504 2800688 debug extra cups-dbg_1.7.1-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQGcBAEBCAAGBQJSzs59AAoJEIvPpx7KFjRVVvEL/iVnXyLw2RXr8jqM970F8Zh/
PaCWS3dHndQNs3EPJ9dy8HTbUnjEP7bDNn+WMfvWFXlmdlR1mAsj+LEX/spjjnTf
DdUqP/NeeNvShcX1VZp4zsC8KnnQDL6sGNCimB7eL7dPA+9aMkc8HqisoQoPusSf
cIoga5idLILrhnKDZklaPS2ageIVPr5/GtDKLb0LdFuhpRgg3ZueWUBEVEv39BUA
Nm/nrHA9Fn3I4yCZqyadt5olPi2w3Mg+phey6snY9TmUrcRHhNquEa0o5uRloxuD
X0JD96qKff/aoN8BeB25FS7J0Towj05Nv6//lkwkohEWCbOcFVl9BxGMs2Fsk9CZ
4YpIemTCs5iIJK8qRPHxM+YnoJV9ICmOgqnA+8pJlnhmNMs3UL7PK3eGzdXt7+S5
Bcrlifj85n2QCb+MkyYzt4kjGMmSll9Sp50kA2LJ6Z9Ze6yReh61j1POkknb749r
USyPl3ahUyu/yA61JQ3/HJhJIkGazvT9hMillCfGog==
=A9sI
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: