[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#734670: cups: Honour DEB_BUILD_OPTIONS=nocheck to allow bootstrapping



Source: cups
Version: 1.6.4
Severity: normal
Tags: patch

cups build-depends on libcupsfilters-dev (from cups-filters) and
cups-filters build-depends on libcups2-dev (from cups). This means that
in a port bootstrap neither of these package can be built first.

This patch allows the untangling of this curcular build-dependency by
allowing cups to honour the 'nocheck' build-option which skips tests.
(recommended in
http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules-options
)

Because cups only need cups-filters for the test, this is all that is needed.

A later patch will supply annotations to the Build-Depends, allowing
full automation, but that is not yet suitable for the archive. Having
the mechanism present in the rules file is still very useful to porters.
(I just used it for the arm64 bootstrap).

See https://wiki.debian.org/DebianBootstrap for more info on this general subject.

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Description: Honour DEB_BUILD_OPTIONS=nocheck
This allows bootstraping because cups-filters and libcupsfilters-dev 
dependencies are only needed for tests. Ideally DEB_BUILD_PROFILES 
annotations of the build-deps to record this would accompany this patch, 
but they are not yet suitable for the archive, so that will come later.

Author: wookey <wookey@wookware.org>  Sat, 04 Jan 2014 00:24:54 +0000


diff -Nru cups-1.6.4/debian/rules cups-1.6.4/debian/rules
--- cups-1.6.4/debian/rules	2013-10-02 08:36:50.000000000 +0000
+++ cups-1.6.4/debian/rules	2014-01-04 00:23:58.000000000 +0000
@@ -135,7 +135,9 @@
 	dh_fixperms -Xusr/lib/cups/backend-available
 
 override_dh_auto_test:
+ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
 	make check
+endif
 
 ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
 override_dh_makeshlibs:

Reply to: