Bug#718798: cups-daemon: suggestions for init script: bashisms, lsb...
On Sat, Jan 04, 2014 at 02:19:43PM +0100, Didier 'OdyX' Raboud wrote:
> Control: tags -1 +pending +patch
>
> Hi Nicolas,
>
> Le lundi, 5 août 2013, 17.03:55 Nicolas Boulenguez a écrit :
> > Hello. Please consider the attached changes, inspired by
> > /etc/init.d/skeleton and
> > http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-gene
> > ric/iniscrptact.html. The skeleton may suggest many other easy
> > improvements in calls to start-stop-daemon, but I lack knowledge of
> > CUPS to decide such changes.
>
> Awesome, thank you very much. I have applied most of your changes but
> one:
>
> > Include /lib/init/vars.sh and respect VERBOSE when appropriate.
>
> I'm a very skeptical about the use of the VERBOSE variable in general
> and don't think the individual initscripts should handle that. Boot
> verbosity should be controlled directly by the init daemon, not spread
> in all packages, IMHO.
Plus, this is really a private implementation detail of the initscripts
package. It's not really intended to be used by scripts outside this
package, not least of which is that it would introduce unnecessary
compatibility problems should the script be updated.
Thanks,
Roger
--
.''`. Roger Leigh
: :' : Debian GNU/Linux http://people.debian.org/~rleigh/
`. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools
`- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
Reply to: