Bug#702248: Non-optimal boot priority/dependency of service 'cups'

["Didier 'OdyX' Raboud" <odyx@debian.org>]

Control: tags -1 +patch

Hi Roger,

Le lundi, 4 mars 2013 21.29:26, Roger Leigh a écrit :
> Why can't we add
>   Should-Start: xxx
> to the init script here?

One-line patch attached.

> This seems like a reasonable request, there are no dependency loops,
> and the init system can cater for this need, so why should this not
> just work by default?  It's just a one line change to the init
> script.

The concern I have with adding this is that it makes the cups init script 
start after nslcd/slapd also in the default configuration, for unneeded 
reasons. Trying to cope with all possible configuration changes feels like 
opening the can of worms.

So, I stand to my general "let's not try to cope with the world of change 
possibilities offered to the admin" but will apply this change to cups 1.6.1+ 
in experimental. For users of other suites, /etc/init.d/cups is a 
configuration file, one can apply the attached patch directly.

Cheers,

OdyX

From a05144e0895eecd7b71907c5b36e9eb8fcc01f07 Mon Sep 17 00:00:00 2001
From: Didier Raboud <odyx@debian.org>
Date: Tue, 5 Mar 2013 18:18:39 +0100
Subject: [PATCH] Add slapd and nslcd to cups' Should-Start LSB headers

Closes: #702248
---
 debian/cups-daemon.cups.init |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/cups-daemon.cups.init b/debian/cups-daemon.cups.init
index 89ceebe..ded2fde 100644
--- a/debian/cups-daemon.cups.init
+++ b/debian/cups-daemon.cups.init
@@ -3,7 +3,7 @@
 # Provides:          cups
 # Required-Start:    $syslog $remote_fs
 # Required-Stop:     $syslog $remote_fs
-# Should-Start:      $network avahi
+# Should-Start:      $network avahi slapd nslcd
 # Should-Stop:       $network
 # X-Start-Before:    samba
 # X-Stop-After:      samba
-- 
1.7.10.4