[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692431: marked as done (hplip: kde4-kdesudo-support.dpatch is broken (fix attached))

Your message dated Mon, 4 Mar 2013 09:38:59 +0400
with message-id <CAKimPHWtvu46D2b=OeKTh6PQKhv+QMo__2PjhwwfLYSZ0++rdg@mail.gmail.com>
and subject line Re: hplip: kde4-kdesudo-support.dpatch is broken (fix attached)
has caused the Debian Bug report #692431,
regarding hplip: kde4-kdesudo-support.dpatch is broken (fix attached)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
692431: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692431
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: hplip
Version: 3.12.10a-1
Severity: normal
Tags: patch

Dear maintainers,

The kde4-kdesudo-support.dpatch tries to all "utils.which" function
which is not defined.

This causes hp-toolbox to crash with a traceback. Example:

| Traceback (most recent call last):
|   File "/usr/bin/hp-diagnose_queues", line 251, in <module>
|     if add_group(core) is False:
|   File "/usr/bin/hp-diagnose_queues", line 93, in add_group
|     su_sudo = utils.su_sudo()
|   File "/usr/share/hplip/base/utils.py", line 1782, in su_sudo
|     elif utils.which('/usr/lib/kde4/libexec/kdesu'):
| NameError: global name 'utils' is not defined

A patch that fixes this is attached.

Thanks for considering the patch,
--
Dmitry Shachnev

diff -Nru hplip-3.12.6/debian/patches/kde4-kdesudo-support.dpatch hplip-3.12.6/debian/patches/kde4-kdesudo-support.dpatch
--- hplip-3.12.6/debian/patches/kde4-kdesudo-support.dpatch	2012-05-26 04:25:50.000000000 +0400
+++ hplip-3.12.6/debian/patches/kde4-kdesudo-support.dpatch	2012-10-21 13:42:36.000000000 +0400
@@ -13,10 +13,10 @@
      if which('kdesu'):
          su_sudo_str = 'kdesu -- %s'
  
-+    elif utils.which('/usr/lib/kde4/libexec/kdesu'):
++    elif os.path.isfile('/usr/lib/kde4/libexec/kdesu'):
 +        su_sudo_str = '/usr/lib/kde4/libexec/kdesu -- %s'
 +
-+    elif utils.which('kdesudo'):
++    elif which('kdesudo'):
 +        su_sudo_str = 'kdesudo -- %s'
 +
      elif which('gnomesu'):

--- End Message ---
--- Begin Message --- 
Version: 3.12.11-1

This was fixed in 3.12.11-1 (which only referenced LP bug, not this one).

--
Dmitry Shachnev

--- End Message ---
Reply to: