Bug#475873: Serious bug was config files left around after switch to ghostscript?
tags 475873 +patch
severity 475873 serious
thanks
Le vendredi, 3 août 2012 10.19:13, Bastien ROUCARIES a écrit :
> I think this bug #475873 is serious, and should be fixed before stable.
>
> What do you think ?
Indeed, rising severity.
I think that has already been addressed in #333474 with a "rm -Rf" but has
been reverted in 8.60.dfsg.2-0ubuntu2 (gutsy), itself included in
8.61.dfsg.1~svn8187-1 (unstable):
* debian/ghostscript.preinst:
- Remove "rm -rf /etc/ghostscript /etc/gs-gpl" insanity.
So these files should have gotten removed before the Lenny release for people
having installed all intermediate versions but wouldn't have fr people dist-
upgrading directly between Etch (with gs-gpl 8.54.dfsg.1-5etch2) and Lenny
(with ghostcript 8.62.dfsg.1-3.2lenny5 ).
> It is a matter of dpkg-maintscript-helper rm_conffile file in the
> ghostscript maintener script.
As far as I understand, these files were either generated or downloaded
(probably the first), so they are not "dpkg conffiles" (so dpkg-maintscript-
helper can't check if they have been modified). So I propose to re-add the "rm
-rf" insanity for Wheezy, only on upgrade to the next version. Patches are
attached (with yet-another git commit policy :-p ).
Cheers,
OdyX
From e525a6f06e43b407e57fcdd14ae6ae9a3e7688c6 Mon Sep 17 00:00:00 2001
From: Didier Raboud <odyx@debian.org>
Date: Fri, 3 Aug 2012 11:54:17 +0200
Subject: [PATCH 1/2] In preinst, remove /etc/gs-gpl that might have stayed around in Etch-Lenny dist-upgrades.
Closes: #475873
---
debian/ghostscript.preinst | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/debian/ghostscript.preinst b/debian/ghostscript.preinst
index 853160b..544e5a0 100644
--- a/debian/ghostscript.preinst
+++ b/debian/ghostscript.preinst
@@ -4,6 +4,12 @@ set -e
case "$1" in
install|upgrade)
+ # Make sure the /etc/gs-gpl/ files are actually gone
+ # (they might have stayed around during a Etch-Lenny dist-upgrade).
+ if dpkg --compare-versions "$2" lt-nl "9.05~dfsg-6+UNRELEASED"; then
+ rm -rf /etc/gs-gpl/
+ fi
+
# Do away with update-alternative for /usr/bin/gs, we have one
# grand unified Ghostscript now!
if dpkg --compare-versions "$2" lt-nl "8.63.dfsg.1-1"; then
--
1.7.2.5
From 170f897c70155f35011c826f41a5f1361bf318fb Mon Sep 17 00:00:00 2001
From: Didier Raboud <odyx@debian.org>
Date: Fri, 3 Aug 2012 12:03:26 +0200
Subject: [PATCH 2/2] Changelog entry for the previous commit.
---
debian/changelog | 5 +++++
debian/ghostscript.preinst | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 2f94a6a..0f3d589 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,6 @@
ghostscript (9.05~dfsg-7) UNRELEASED; urgency=low
+ [ Jonas Smedegaard ]
* Clarify consequences of linking against shared libjpeg (i.e. not
setting custom D_MAX_BLOCKS_IN_MCU).
Closes: bug#582522. Thanks to Bastien ROUCARIÈS.
@@ -22,6 +23,10 @@ ghostscript (9.05~dfsg-7) UNRELEASED; urgency=low
* Add patch cherry-picked upstream, to improve error feedback.
Closes: bug#682407. Thanks to Bastien ROUCARIÈS and Chris Liddell.
+ [ Didier Raboud ]
+ * In preinst, remove /etc/gs-gpl that might have stayed around in
+ Etch-Lenny dist-upgrades. (Closes: #475873)
+
-- Jonas Smedegaard <dr@jones.dk> Tue, 24 Jul 2012 20:54:10 +0200
ghostscript (9.05~dfsg-6) unstable; urgency=low
diff --git a/debian/ghostscript.preinst b/debian/ghostscript.preinst
index 544e5a0..51590dc 100644
--- a/debian/ghostscript.preinst
+++ b/debian/ghostscript.preinst
@@ -6,7 +6,7 @@ case "$1" in
install|upgrade)
# Make sure the /etc/gs-gpl/ files are actually gone
# (they might have stayed around during a Etch-Lenny dist-upgrade).
- if dpkg --compare-versions "$2" lt-nl "9.05~dfsg-6+UNRELEASED"; then
+ if dpkg --compare-versions "$2" lt-nl "9.05~dfsg-7"; then
rm -rf /etc/gs-gpl/
fi
--
1.7.2.5
Reply to: