[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#625925: Uses incorrect path to default colour profile



On Tue, May 10, 2011 at 09:27:29 +0100, Roger Leigh wrote:

> forwarded 625925 https://sourceforge.net/tracker/?func=detail&aid=3299815&group_id=1537&atid=101537
> thanks
> 
> On Tue, May 10, 2011 at 03:02:53AM +0100, Ben Hutchings wrote:
> > On Sat, 2011-05-07 at 10:54 +0100, Roger Leigh wrote:
> > > On Sat, May 07, 2011 at 05:17:58AM +0100, Ben Hutchings wrote:
> > > > Printing to my HP LaserJet 4Plus currently fails.  The error message
> > > > for the job is:
> > > > 
> > > > File '/System/Library/ColorSync/Profiles/sRGB Profile.icc' not found
> > > > 
> > > > This path is presumably correct for OS X but obviously not for Linux!
> > > > It is present in the /usr/lib/cups/driver/gutenprint.5.2 binary.
> > > 
> > > This path is unconditionally put into generated PPD files by genppd.c:
> > This seems like a big problem, since cups recommends gutenprint over
> > foomatic (and I found the latter does work for me).
> 
> Forwarded upstream.  In the interim we can patch out that block of
> code.
> 
So would the following make sense then?  It seems there's been 0
followup to your upstream report, so I'm happy to do a QA upload with
that patch if you think it's ok (I don't have a printer, so can't test
this either)...  Another option is to remove gutenprint and photoprint
from wheezy.

Cheers,
Julien

From: Julien Cristau <jcristau@debian.org>
Date: Sun, 1 Jan 2012 17:49:09 +0100
Subject: [PATCH] genppd: don't write color profile information with broken
 macos-specific paths

Closes: #625925
---
 src/cups/genppd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/cups/genppd.c b/src/cups/genppd.c
index 4e85388..6153371 100644
--- a/src/cups/genppd.c
+++ b/src/cups/genppd.c
@@ -1873,6 +1873,7 @@ write_ppd(
 		   manufacturer, device_id, ppd_location, language, po,
 		   all_langs);
 
+#if 0
   /* Macintosh color management */
   gzputs(fp, "*cupsICCProfile Gray../Grayscale:	\"/System/Library/ColorSync/Profiles/sRGB Profile.icc\"\n");
   gzputs(fp, "*cupsICCProfile RGB../Color:	\"/System/Library/ColorSync/Profiles/sRGB Profile.icc\"\n");
@@ -1880,6 +1881,7 @@ write_ppd(
   gzputs(fp, "*APSupportsCustomColorMatching: true\n");
   gzputs(fp, "*APDefaultCustomColorMatchingProfile: sRGB\n");
   gzputs(fp, "*APCustomColorMatchingProfile: sRGB\n");
+#endif
 
   gzputs(fp, "\n");
 

Attachment: signature.asc
Description: Digital signature


Reply to: