[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#555361: hplip: Embedded code copy of python-pexpect



* Mark Purcell <msp@debian.org>, 2009-11-29, 16:26:
Please modify your package to use the system-wide module provided by
the python-pexpect package.

Btw, do you have some advice on how best to modify the package?

You should:

1. Assure that copy of pexpect.py bundled in the package is either unmodified or the package does not rely on any non-standard behaviour. (This doesn't seem to be the issue for hplip, it uses pexpect in a very basic way.)

2. Check how the package imports pexpect and possibly fix the imports. ("import pexpect", "import pexpect as ...", "from pexpect import ..." are OK.)

3. Add appropriate Depends: or Recommends: header(s).

4. Don't let the embedded pexpect.py be installed into binary packages (either by fixing *.install files or debian/rules).

5. Last but not least, test the package thoroughly.

Hope that helps,

--
Jakub Wilk

Attachment: signature.asc
Description: Digital signature


Reply to: