[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#494429: [Pkg-hpijs-devel] Bug#494429: hplip: hp-check won't detect cups version : should be error or warning ?



Hello Mark,

Mark Purcell wrote:
Version: 3.9.8-1

On Sunday 01 November 2009 19:44:47 Giacomo A. Catenazzi wrote:
Hello,

this is a moer general problem:
hp-check check the wrong things (or the package dependencies are
wrong).


hplip now will advise if it is a run time checks or build time checks:

Really I mean only the runtime dependencies, and IMO these are:
or wrong checks (thus misleading) or wrong dependency on debian/control.

Try to install hplip in a new minimal system (without gnome and KDE):
hp-check -r will give a lot of errors in dependencies.


Note: hp-check can be run in three modes:
1. Compile-time check mode (-c or --compile): Use this mode before compiling the HPLIP supplied tarball (.tar.gz or .run) to determine if the proper dependencies are installed to successfully compile HPLIP. 2. Run-time check mode (-r or --run): Use this mode to determine if a distro supplied package (.deb, .rpm, etc) or an already built HPLIP supplied tarball has the proper dependencies installed to successfully run. 3. Both compile- and run-time check mode (-b or --both) (Default): This mode will check both of the above cases (both compile- and run-time dependencies).

In this case:
hp-check execute "cups-config --version", but this command is available
only on cups-dev.


Checking for dependency: CUPS devel- Common Unix Printing System development files...
error: NOT FOUND! This is a REQUIRED/COMPILE TIME ONLY dependency. Please make sure that this dependency is installed before installing or running HPLIP.

No, I mean line 326 of hp-check:

:    log.info(log.bold("Checking for CUPS..."))
:    cups_ok = True
:
:    status, output = utils.run('lpstat -r')

Note: this command prints also a "scheduler is running", which is IMHO
not so nice and newbies friendly.

:    if status == 0:
:        log.info("Status: %s" % output.strip())
:    else:
: log.error("Status: (Not available. CUPS may not be installed or not running.)")
:        cups_ok = False
:        num_errors += 1
:
:    if cups_ok:
:        status, output = utils.run('cups-config --version')
:        if status == 0:
:            log.info("Version: %s" % output.strip())
:        else:
: log.error("Version: (Not available. CUPS may not be installed or not running.)")
:            cups_ok = False
:            num_errors += 1


This part last check is wrong: CUPS is installed, but the program uses
a cups-dev command. IMHO it should get the CUPS version using
an other method.


hp-check is only informative, but IMHO could give trouble to users
(as far I saw googling when solving my printer problem).

ciao
	cate





Reply to: