[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#519966: marked as done (hplip-data package contains .pyc files because of wrong dh_python)



Your message dated Tue, 17 Mar 2009 09:47:11 +0000
with message-id <E1LjVt9-0008QJ-09@ries.debian.org>
and subject line Bug#519966: fixed in hplip 3.9.2-3
has caused the Debian Bug report #519966,
regarding hplip-data package contains .pyc files because of wrong dh_python
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
519966: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=519966
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: hplip-data
Version: 3.9.2-1
Severity: serious
Justification: python policy 2.6
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch jaunty

Running 'debsums -s' on my system, I found a large number of checksum
mismatches for files under /usr/share/hplip.  The reason for this is that
hplip-data incorrectly ships a number of .pyc files within the package,
which has been a violation of python packaging policy as long as there has
been a python packaging policy.

The debian/rules for some reason calls dh_pysupport for the Architecture:
any packages, when hplip-data, containing the .py files, is an arch: all
package.  The attached patch fixes this so that the .py files are actually
registered with python-support.

The hplip.preinst code to remove all .pyc and .pyo files on upgrade of the
*hplip* package is probably also unnecessary with this change.  (Even if
it's not unnecessary, it is wrong.  The hplip package shouldn't be doing
anything with .pyc files originating with another binary package.)

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org
diff -Nru hplip-3.9.2/debian/changelog hplip-3.9.2/debian/changelog
--- hplip-3.9.2/debian/changelog	2009-03-16 13:46:37.000000000 +0000
+++ hplip-3.9.2/debian/changelog	2009-03-16 13:46:39.000000000 +0000
@@ -1,3 +1,17 @@
+hplip (3.9.2-1ubuntu3) jaunty; urgency=low
+
+  * Also add missing ${python:Depends} to hplip-data.
+
+ -- Steve Langasek <steve.langasek@ubuntu.com>  Mon, 16 Mar 2009 13:30:57 +0000
+
+hplip (3.9.2-1ubuntu2) jaunty; urgency=low
+
+  * The python scripts are in hplip-data - call dh_pysupport -i, not
+    dh_pysupport -a, so we don't end up shipping .pyc files in the
+    package!
+
+ -- Steve Langasek <steve.langasek@ubuntu.com>  Mon, 16 Mar 2009 12:50:52 +0000
+
 hplip (3.9.2-1ubuntu1) jaunty; urgency=low
 
   [ Till Kamppeter ]
diff -Nru hplip-3.9.2/debian/control hplip-3.9.2/debian/control
--- hplip-3.9.2/debian/control	2009-03-16 13:46:37.000000000 +0000
+++ hplip-3.9.2/debian/control	2009-03-16 13:46:39.000000000 +0000
@@ -54,7 +54,7 @@
 Package: hplip-data
 Architecture: all
 Recommends: hplip
-Depends: python
+Depends: ${python:Depends}
 Description: HP Linux Printing and Imaging - data files
  This package contains data files for the HP Linux Printing and
  Imaging System.
diff -Nru hplip-3.9.2/debian/rules hplip-3.9.2/debian/rules
--- hplip-3.9.2/debian/rules	2009-03-16 13:46:37.000000000 +0000
+++ hplip-3.9.2/debian/rules	2009-03-16 13:46:39.000000000 +0000
@@ -326,8 +326,8 @@
 	dh_compress -i
 	dh_fixperms -i
 #	dh_perl -i
-#	dh_pysupport -i
-#	dh_python -i /usr/share/hplip
+	dh_pysupport -i /usr/share/hplip
+	dh_python -i /usr/share/hplip
 #	dh_makeshlibs -i
 	dh_installdeb -i
 	dh_shlibdeps -i --dpkg-shlibdeps-params=--ignore-missing-info
@@ -362,8 +362,6 @@
 	dh_installman -a
 #	dh_installinfo -a
 	dh_installchangelogs -a $(CHANGELOG)
-	dh_pysupport -a /usr/share/hplip
-	dh_python -a /usr/share/hplip
 	# must come after dh_pysupport and dh_python, or the postinst
 	# ordering will be screwed up and break.
 	#dh_installinit -phplip --init-script=hplip -- multiuser 19

--- End Message ---
--- Begin Message ---
Source: hplip
Source-Version: 3.9.2-3

We believe that the bug you reported is fixed in the latest version of
hplip, which is due to be installed in the Debian FTP archive:

hpijs-ppds_3.9.2-3_all.deb
  to pool/main/h/hplip/hpijs-ppds_3.9.2-3_all.deb
hpijs_3.9.2-3_i386.deb
  to pool/main/h/hplip/hpijs_3.9.2-3_i386.deb
hplip-data_3.9.2-3_all.deb
  to pool/main/h/hplip/hplip-data_3.9.2-3_all.deb
hplip-dbg_3.9.2-3_i386.deb
  to pool/main/h/hplip/hplip-dbg_3.9.2-3_i386.deb
hplip-doc_3.9.2-3_all.deb
  to pool/main/h/hplip/hplip-doc_3.9.2-3_all.deb
hplip-gui_3.9.2-3_all.deb
  to pool/main/h/hplip/hplip-gui_3.9.2-3_all.deb
hplip_3.9.2-3.diff.gz
  to pool/main/h/hplip/hplip_3.9.2-3.diff.gz
hplip_3.9.2-3.dsc
  to pool/main/h/hplip/hplip_3.9.2-3.dsc
hplip_3.9.2-3_i386.deb
  to pool/main/h/hplip/hplip_3.9.2-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 519966@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mark Purcell <msp@debian.org> (supplier of updated hplip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 17 Mar 2009 20:24:47 +1100
Source: hplip
Binary: hplip hplip-data hplip-gui hplip-dbg hplip-doc hpijs-ppds hpijs
Architecture: source all i386
Version: 3.9.2-3
Distribution: unstable
Urgency: low
Maintainer: Debian HPIJS and HPLIP maintainers <pkg-hpijs-devel@lists.alioth.debian.org>
Changed-By: Mark Purcell <msp@debian.org>
Description: 
 hpijs      - HP Linux Printing and Imaging - gs IJS driver (hpijs)
 hpijs-ppds - HP Linux Printing and Imaging - HPIJS PPD files
 hplip      - HP Linux Printing and Imaging System (HPLIP)
 hplip-data - HP Linux Printing and Imaging - data files
 hplip-dbg  - HP Linux Printing and Imaging - debugging information
 hplip-doc  - HP Linux Printing and Imaging - documentation
 hplip-gui  - HP Linux Printing and Imaging - GUI utilities
Closes: 519966
Changes: 
 hplip (3.9.2-3) unstable; urgency=low
 .
   [ Steve Langasek ]
   * Add missing ${python:Depends} to hplip-data.
   * The python scripts are in hplip-data - call dh_pysupport -i, not
     dh_pysupport -a, so we don't end up shipping .pyc files in the
     package!  (Closes: #519966)
 .
   [ Mark Purcell ]
   * Do not remove .pyc/.pyo on upgrades
Checksums-Sha1: 
 8486edc90a4702ce36d8899c49c3b0de4a3ed5f8 1685 hplip_3.9.2-3.dsc
 293c3de3cdb3778b220b9931cc28af5c1c407084 77817 hplip_3.9.2-3.diff.gz
 473e7c68ad0b94810644a08eb34e64408d90d73d 7097876 hplip-data_3.9.2-3_all.deb
 e184af8dbec280fa452c8de7958acd9210cecd1e 55444 hplip-gui_3.9.2-3_all.deb
 d785a04af5b99c8ece0f4a47ff838772dbd803d8 655544 hplip-doc_3.9.2-3_all.deb
 3f186adfa881cf2889f3eca21ad61808f029e774 2964916 hpijs-ppds_3.9.2-3_all.deb
 19150c607bb8780b37ae6620bef389e1068087fa 313982 hplip_3.9.2-3_i386.deb
 68a628888c2c6398398ed66a6a7e6fb315d21e88 808346 hplip-dbg_3.9.2-3_i386.deb
 8633cc397d703e3b60ba746865d838134bc8adf4 369520 hpijs_3.9.2-3_i386.deb
Checksums-Sha256: 
 6feafafe111e188c58357e548c5d6f1005039b0e68b84a4a78e002c95f5f2951 1685 hplip_3.9.2-3.dsc
 e4dfeaeaae4372c9d2d8aee57345057617f94166d624dc8286f44a42a526b530 77817 hplip_3.9.2-3.diff.gz
 7dcb68140699362707b66b8c6ac2647287cf4eac7eee7b78159a30e182a5b996 7097876 hplip-data_3.9.2-3_all.deb
 938de202b3a2a560b8cdd6cc48b5b1a98113d40ce2feccde58d63c6def016c29 55444 hplip-gui_3.9.2-3_all.deb
 f03c46b5cb51c365748f87593c1cbff799c0fa558afd196e1610b7792e870a03 655544 hplip-doc_3.9.2-3_all.deb
 e0d7db3ecb42b152a52f81b10d6234d4d0851ce7221894337c46a68b096c4843 2964916 hpijs-ppds_3.9.2-3_all.deb
 c858e6e53650a2bb74495faf9dfcaeb1c8ee81df8054ec5aa1f59804bba70b31 313982 hplip_3.9.2-3_i386.deb
 a65d46fc9bcd7d3fdc9e129dcd8d50f73fb34aa91f285c36e9b7b7197d0d1342 808346 hplip-dbg_3.9.2-3_i386.deb
 c5cae628aafae73da559e93ee5f2bdfec3fdca8bb9fbb1e4c14b5e13f31eb0e2 369520 hpijs_3.9.2-3_i386.deb
Files: 
 20b7f8e2892236591451eeb45d28f365 1685 utils optional hplip_3.9.2-3.dsc
 346add1f3d7adfcb3a846b5dcd09e62b 77817 utils optional hplip_3.9.2-3.diff.gz
 effa6220ca54dee11df2dd2e222bae7c 7097876 utils optional hplip-data_3.9.2-3_all.deb
 5cf6348539d7ab388df8f984ec527500 55444 utils optional hplip-gui_3.9.2-3_all.deb
 56717e785a5a4119c53c7ce5aa97439e 655544 doc optional hplip-doc_3.9.2-3_all.deb
 f46b4409f5863f46d0fc455264423706 2964916 utils optional hpijs-ppds_3.9.2-3_all.deb
 0e3918cb80ad6f92f726d0c60b71c674 313982 utils optional hplip_3.9.2-3_i386.deb
 8adf76276c6a649ddcba9597839315d0 808346 utils extra hplip-dbg_3.9.2-3_i386.deb
 e9aae44fbe347edae7f3415efc54e991 369520 text optional hpijs_3.9.2-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkm/bQUACgkQoCzanz0IthKKRwCfXQTSluX5MVnD9bBWGN7p3f53
3G8An3sz+hjs7lVxLTCw6QHwM6s64CFa
=eK/4
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: