[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#385605: cupsys: All options ignored when printing from Windows



Package: cupsys
Version: 1.2.2-2
Severity: normal
Tags: patch

After upgrading from stable, we found that cups stopped doing anything 
with print options from Windows machines.  It turns out this is a known 
bug:

http://www.cups.org/str.php?L1839

I tested the patch supplied with that bug report, and indeed it fixed 
the problem.  I'm attaching that patch here.

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16.27
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages cupsys depends on:
ii  adduser                  3.97            Add and remove users and groups
ii  cupsys-common            1.2.2-2         Common UNIX Printing System(tm) - 
ii  debconf [debconf-2.0]    1.5.3           Debian configuration management sy
ii  gs-esp                   8.15.2.dfsg.1-2 The Ghostscript PostScript interpr
ii  libc6                    2.3.6.ds1-4     GNU C Library: Shared libraries
ii  libcupsimage2            1.2.2-2         Common UNIX Printing System(tm) - 
ii  libcupsys2               1.2.2-2         Common UNIX Printing System(tm) - 
ii  libdbus-1-2              0.62-4          simple interprocess messaging syst
ii  libgnutls13              1.4.2-1         the GNU TLS library - runtime libr
ii  libldap2                 2.1.30-13+b1    OpenLDAP libraries
ii  libpam0g                 0.79-3.1        Pluggable Authentication Modules l
ii  libpaper1                1.1.19          Library for handling paper charact
ii  libslp1                  1.2.1-5         OpenSLP libraries
ii  lsb-base                 3.1-14          Linux Standard Base 3.1 init scrip
ii  patch                    2.5.9-4         Apply a diff file to an original
ii  perl-modules             5.8.8-6.1       Core Perl modules
ii  poppler-utils [xpdf-util 0.4.5-4.1       PDF utilitites (based on libpopple
ii  procps                   1:3.2.7-2       /proc file system utilities
ii  zlib1g                   1:1.2.3-13      compression library - runtime

Versions of packages cupsys recommends:
ii  cupsys-client           1.2.2-2          Common UNIX Printing System(tm) - 
ii  foomatic-filters        3.0.2-20060712-1 linuxprinting.org printer support 
ii  smbclient               3.0.22-1         a LanManager-like simple client fo

-- debconf information:
* cupsys/raw-print: true
* cupsys/backend: ipp, lpd, socket
Index: pstops.c
===================================================================
--- pstops.c	(revision 5871)
+++ pstops.c	(working copy)
@@ -1587,6 +1587,10 @@
       break;
   }
 
+  puts("%%BeginSetup");
+  
+  do_setup(doc, ppd);
+
   if (!strncmp(line, "%%BeginSetup", 12))
   {
     while (strncmp(line, "%%EndSetup", 10))
@@ -1603,7 +1607,7 @@
 	  doc->num_options = include_feature(ppd, line, doc->num_options,
                                              &(doc->options));
       }
-      else
+      else if (strncmp(line, "%%BeginSetup", 12))
         fwrite(line, 1, linelen, stdout);
 
       if ((linelen = cupsFileGetLine(fp, line, linesize)) == 0)
@@ -1615,11 +1619,7 @@
     else
       fputs("ERROR: Missing %%EndSetup!\n", stderr);
   }
-  else
-    puts("%%BeginSetup");
 
-  do_setup(doc, ppd);
-
   puts("%%EndSetup");
 
   return (linelen);

Reply to: