[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#368446: cupsys-driver-gutenprint: patch for cups-genppdupdate.5.0



* Roger Leigh <rleigh@whinlatter.ukfsn.org> [2006-05-22 19:11]:
> Nice catch, thanks!

You're welcome ;-)

> I've applied your patch (with a small change to the indentation), as

Are you referring to the fact that I *refuse* to use tabs *ever* ?

> well as fixing the postinst problem Jonas reported.  The changes are:

Jonas didn't look properly (and apparently neither did you). If you
had, you would have noticed that cups-genppdconfig.5.0 is not being
run twice: the "second run" is actually cups-genppdupdate.5.0:
  /usr/sbin/cups-genppdconfig.5.0 -u
  /usr/sbin/cups-genppdupdate.5.0
I must admit, however, that the mistake was easy to make ;-)

>   * debian/cupsys-driver-gutenprint.postinst: Don't run
>     /usr/sbin/cups-genppdconfig.5.0 a second time with no arguments.
>   * debian/rules: Unconditionally set DIALOG when running configure.
>   * src/cups/cups-genppdupdate.in: Don't freeze waiting on stdin when
>     running egrep.  Patch installed as
>     debian/patches/06_genppdupdate_egrep_stdin_freeze.dpatch; thanks to
>     Felix C. Stegerman for identifying the fault and providing the patch
>     (Closes: #368446).
> 
> I've uploaded some test packages to
> http://people.debian.org/~rleigh/gutenprint/sid/5.0.0-rc3-2/
> 
> Please could you try these out and let me know if it fixes the
> problem?
> 
> You might need to rebuild the source, since I don't have an amd64.

I'm on ppc (iBook G4), so I'll just use the ones you provide.

> I'll forward your patch upstream once we know it fixes the problem.

Please revert the postinst script to the original (correct) version
and I'll be happy to try the test packages.


- Felix

-- 
Felix C. Stegerman <flx@obfusk.net>

"Any sufficiently advanced bug is indistinguishable from a feature."
 -- R. Kulawiec

Attachment: pgpDkUJimPLUZ.pgp
Description: PGP signature


Reply to: