Bug#321599: marked as done (libgutenprintui2-1: saved settings garbled with Auto orientation and PPI scaling)
Your message dated Sun, 14 Aug 2005 16:02:07 -0700
with message-id <E1E4RUV-0004e1-00@spohr.debian.org>
and subject line Bug#321599: fixed in gutenprint 4.3.99+cvs20050813-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Aug 2005 12:29:39 +0000
>From dtorop934@gmail.com Sat Aug 06 05:29:39 2005
Return-path: <dtorop934@gmail.com>
Received: from rproxy.gmail.com [64.233.170.201]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1E1No3-0002ak-00; Sat, 06 Aug 2005 05:29:39 -0700
Received: by rproxy.gmail.com with SMTP id g11so716252rne
for <submit@bugs.debian.org>; Sat, 06 Aug 2005 05:29:37 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
s=beta; d=gmail.com;
h=received:content-type:mime-version:content-transfer-encoding:from:to:subject:x-mailer:date:message-id;
b=FHD1Oj65ILa3ICGF3DQCSK5OE8/0094JVQjUYqnHzfsQ1Hms74kr9rR3IzQRG+gM4XM23sZM4RjIvWrKCbzrQS3QMgOPgcKDPngqGHOEIasw+ZtpZn0himEjmNY7bDE+ahJMss6Yk2JpQEzs5aEE4xxiLVBqCSA3vGZ/UKMJJto=
Received: by 10.38.76.79 with SMTP id y79mr1748917rna;
Sat, 06 Aug 2005 05:29:37 -0700 (PDT)
Received: from houston ([66.108.217.46])
by mx.gmail.com with ESMTP id r34sm4392569rna.2005.08.06.05.29.37;
Sat, 06 Aug 2005 05:29:37 -0700 (PDT)
Received: from dtorop by houston with local (Exim 4.52)
id 1E1Na6-0003DJ-Oe; Sat, 06 Aug 2005 08:15:14 -0400
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Dan Torop <dtorop934@gmail.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: libgutenprintui2-1: saved settings garbled with Auto orientation and PPI
scaling
X-Mailer: reportbug 3.15
Date: Sat, 06 Aug 2005 08:15:14 -0400
Message-Id: <E1E1Na6-0003DJ-Oe@houston>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS,
HAS_PACKAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02
Package: libgutenprintui2-1
Version: 4.3.99+cvs20050801-1
Severity: normal
Tags: patch
For images wider than they are tall, if set up Auto orientation in print
settings dialog, set scaling to PPI, and save settings, when settings
are restored the scaling and positioning may be wrong.
To see an example:
- Create a 500 px wide by 100 px high blank image in Gimp
- Choose File->Print...
- Set page size to letter
- Set the orientation to "Auto".
- Set "scale by" to "ppi"
- Scale to largest image size = minimum PPI (probably about 45 PPI depending on
printer margins)
- Click button to center image horizontally
- Save settings and cancel out of the print dialog.
- Reopen the print dialog
- Settings have change and the scaling is now set to about 60 PPI.
Also, the x&y offsets are different than they were before, the image
is in top left corner of the page.
This appears to be because the first call to do_all_updates() in
src/gutenprintui2 calls set_orientation() before the printable_width and
printable_height globals are set.
I don't know if there is a corresponding bug in libgutenprintui1 and/or
the 4.2.7 code.
Below is a diff of a stopgap fix of the problem. It's an ugly patch, it
just grabs code called later in preview_update() and places it earlier
in the control flow. If someone actually understands gimpprintui2 and
wants to do this right, that would probably be helpful...
diff -ru gutenprint-4.3.99+cvs20050801.orig/src/gutenprintui2/panel.c gutenprint-4.3.99+cvs20050801/src/gutenprintui2/panel.c
--- gutenprint-4.3.99+cvs20050801.orig/src/gutenprintui2/panel.c 2005-06-29 22:38:16.000000000 -0400
+++ gutenprint-4.3.99+cvs20050801/src/gutenprintui2/panel.c 2005-08-06 00:46:15.000000000 -0400
@@ -2630,6 +2630,12 @@
gint
stpui_compute_orientation(void)
{
+ /* if this is called before preview_update() -- which happens on startup --
+ * then printable image area is not yet set */
+ stp_get_imageable_area(pv->v, &left, &right, &bottom, &top);
+ printable_width = right - left;
+ printable_height = bottom - top;
+
if (auto_paper_size ||
(printable_width >= printable_height &&
image_true_width >= image_true_height) ||
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (101, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Versions of packages libgutenprintui2-1 depends on:
ii libatk1.0-0 1.10.1-2 The ATK accessibility toolkit
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libglib2.0-0 2.6.5-1 The GLib library of C routines
ii libgtk2.0-0 2.6.8-1 The GTK+ graphical user interface
ii libgutenprint2 4.3.99+cvs20050801-1 runtime for the Gutenprint printer
ii libpango1.0-0 1.8.2-1 Layout and rendering of internatio
Versions of packages libgutenprintui2-1 recommends:
ii gutenprint-locales 4.3.99+cvs20050801-1 locale data files for Gutenprint
-- no debconf information
---------------------------------------
Received: (at 321599-close) by bugs.debian.org; 14 Aug 2005 23:08:38 +0000
>From katie@spohr.debian.org Sun Aug 14 16:08:38 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1E4RUV-0004e1-00; Sun, 14 Aug 2005 16:02:07 -0700
From: Roger Leigh <rleigh@debian.org>
To: 321599-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#321599: fixed in gutenprint 4.3.99+cvs20050813-1
Message-Id: <E1E4RUV-0004e1-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Sun, 14 Aug 2005 16:02:07 -0700
Delivered-To: 321599-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: gutenprint
Source-Version: 4.3.99+cvs20050813-1
We believe that the bug you reported is fixed in the latest version of
gutenprint, which is due to be installed in the Debian FTP archive:
cupsys-driver-gimpprint_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/cupsys-driver-gimpprint_4.3.99+cvs20050813-1_powerpc.deb
cupsys-driver-gutenprint_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/cupsys-driver-gutenprint_4.3.99+cvs20050813-1_powerpc.deb
escputil_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/escputil_4.3.99+cvs20050813-1_powerpc.deb
foomatic-db-gimp-print_4.3.99+cvs20050813-1_all.deb
to pool/main/g/gutenprint/foomatic-db-gimp-print_4.3.99+cvs20050813-1_all.deb
foomatic-db-gutenprint_4.3.99+cvs20050813-1_all.deb
to pool/main/g/gutenprint/foomatic-db-gutenprint_4.3.99+cvs20050813-1_all.deb
gimp-print_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/gimp-print_4.3.99+cvs20050813-1_powerpc.deb
gutenprint-doc_4.3.99+cvs20050813-1_all.deb
to pool/main/g/gutenprint/gutenprint-doc_4.3.99+cvs20050813-1_all.deb
gutenprint-locales_4.3.99+cvs20050813-1_all.deb
to pool/main/g/gutenprint/gutenprint-locales_4.3.99+cvs20050813-1_all.deb
gutenprint_4.3.99+cvs20050813-1.diff.gz
to pool/main/g/gutenprint/gutenprint_4.3.99+cvs20050813-1.diff.gz
gutenprint_4.3.99+cvs20050813-1.dsc
to pool/main/g/gutenprint/gutenprint_4.3.99+cvs20050813-1.dsc
gutenprint_4.3.99+cvs20050813.orig.tar.gz
to pool/main/g/gutenprint/gutenprint_4.3.99+cvs20050813.orig.tar.gz
ijsgimpprint_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/ijsgimpprint_4.3.99+cvs20050813-1_powerpc.deb
ijsgutenprint_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/ijsgutenprint_4.3.99+cvs20050813-1_powerpc.deb
libgutenprint-dev_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/libgutenprint-dev_4.3.99+cvs20050813-1_powerpc.deb
libgutenprint-doc_4.3.99+cvs20050813-1_all.deb
to pool/main/g/gutenprint/libgutenprint-doc_4.3.99+cvs20050813-1_all.deb
libgutenprint2_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/libgutenprint2_4.3.99+cvs20050813-1_powerpc.deb
libgutenprintui1-1_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/libgutenprintui1-1_4.3.99+cvs20050813-1_powerpc.deb
libgutenprintui1-dev_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/libgutenprintui1-dev_4.3.99+cvs20050813-1_powerpc.deb
libgutenprintui2-1_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/libgutenprintui2-1_4.3.99+cvs20050813-1_powerpc.deb
libgutenprintui2-dev_4.3.99+cvs20050813-1_powerpc.deb
to pool/main/g/gutenprint/libgutenprintui2-dev_4.3.99+cvs20050813-1_powerpc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 321599@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Roger Leigh <rleigh@debian.org> (supplier of updated gutenprint package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 14 Aug 2005 22:20:52 +0100
Source: gutenprint
Binary: libgutenprint-doc libgutenprintui1-1 foomatic-db-gimp-print ijsgimpprint escputil cupsys-driver-gimpprint foomatic-db-gutenprint gimp-print libgutenprintui2-1 gutenprint-locales libgutenprintui2-dev libgutenprintui1-dev libgutenprint-dev ijsgutenprint gutenprint-doc cupsys-driver-gutenprint libgutenprint2
Architecture: source powerpc all
Version: 4.3.99+cvs20050813-1
Distribution: unstable
Urgency: low
Maintainer: Debian Printing Group <debian-printing@lists.debian.org>
Changed-By: Roger Leigh <rleigh@debian.org>
Description:
cupsys-driver-gimpprint - printer drivers for CUPS
cupsys-driver-gutenprint - printer drivers for CUPS
escputil - maintenance utility for Epson Stylus printers
foomatic-db-gimp-print - linuxprinting.org printer support - database for Gimp-Print print
foomatic-db-gutenprint - linuxprinting.org printer support - database for Gutenprint print
gimp-print - print plugin for the GIMP
gutenprint-doc - users' guide for Gutenprint and CUPS
gutenprint-locales - locale data files for Gutenprint
ijsgimpprint - printer drivers for CUPS
ijsgutenprint - inkjet server - Ghostscript driver for Gutenprint
libgutenprint-dev - development files for the Gutenprint printer driver library
libgutenprint-doc - documentation for the Gutenprint printer driver library
libgutenprint2 - runtime for the Gutenprint printer driver library
libgutenprintui1-1 - runtime for the Gutenprint printer driver user interface library
libgutenprintui1-dev - development files for the Gutenprint printer driver user interfac
libgutenprintui2-1 - runtime for the Gutenprint printer driver user interface library
libgutenprintui2-dev - development files for the Gutenprint printer driver user interfac
Closes: 321599 321603
Changes:
gutenprint (4.3.99+cvs20050813-1) unstable; urgency=low
.
* New upstream release candidate.
* src/cups/cups-genppdconfig.in: drop Locale::gettext patch,
which is now incorporated upstream.
* debian/control.in, debian/rules: Use dpatch.
* Added cups-genppdupdate patch as
01_cups_genppdupdate_filename_metacharacters.dpatch
* Don't segfault when using certain paper types with an Epson R800.
Applied patch from Dan Torop as 02_escp2_r800_papers.dpatch
and 03_escp2_colour_adjust_segfault.dpatch (Closes: #321603).
* Don't corrupt print settings under certain conditions, due to
using uninitialised global variables. Applied patch from upstream
based on a patch contributed by Dan Torop as
04_print_settings_corruption.dpatch (Closes: #321599).
* debian/debian/cupsys-driver-gutenprint.postinst: Remove bashisms.
Files:
9ce0d68a452148cd01165a7fab224e18 1210 graphics optional gutenprint_4.3.99+cvs20050813-1.dsc
95bdffd5f0a89588af64a8407b30a934 4565411 graphics optional gutenprint_4.3.99+cvs20050813.orig.tar.gz
7f7dea8fa9bbf214cf41eccda95e6afe 21132 graphics optional gutenprint_4.3.99+cvs20050813-1.diff.gz
a615410ee9db4b54ce6dc42bd73e7c80 249832 doc optional libgutenprint-doc_4.3.99+cvs20050813-1_all.deb
9d47d996d746edb233bb55000a5300c5 178616 libs optional gutenprint-locales_4.3.99+cvs20050813-1_all.deb
77f57552f40b2fd48fa495bd96de3b0d 784332 doc optional gutenprint-doc_4.3.99+cvs20050813-1_all.deb
85ae0cb395f79d0a95abef105a18148a 34760 text optional foomatic-db-gimp-print_4.3.99+cvs20050813-1_all.deb
fd876d91923a361a97ea861be05e8c80 1184688 text optional foomatic-db-gutenprint_4.3.99+cvs20050813-1_all.deb
46405c1628128a672605cf201e3d4a78 109594 graphics optional gimp-print_4.3.99+cvs20050813-1_powerpc.deb
ca1063d648a8adb33d17953d1695b598 34742 graphics optional cupsys-driver-gimpprint_4.3.99+cvs20050813-1_powerpc.deb
6e5b7b59ab9bea39c93363d7f56d990c 985492 graphics optional cupsys-driver-gutenprint_4.3.99+cvs20050813-1_powerpc.deb
763554f2bd442d4a10e010ac2f69416b 82370 libdevel optional libgutenprint-dev_4.3.99+cvs20050813-1_powerpc.deb
53c451336027a9185b72c7ae7cebc9fd 845376 libs optional libgutenprint2_4.3.99+cvs20050813-1_powerpc.deb
e770660b631c9e382bb8091dfcec4fdf 37736 devel optional libgutenprintui1-dev_4.3.99+cvs20050813-1_powerpc.deb
ae7a109b2cabec07a4dd0e0fd14e93be 100634 libs optional libgutenprintui1-1_4.3.99+cvs20050813-1_powerpc.deb
aee0a43789240db21ecfdd894c5d97bd 39742 devel optional libgutenprintui2-dev_4.3.99+cvs20050813-1_powerpc.deb
fdf460c9e75fc72f239f7367b31edf0b 110530 libs optional libgutenprintui2-1_4.3.99+cvs20050813-1_powerpc.deb
a89185c12286c6e303cb7748ebe8e6cb 71620 utils optional escputil_4.3.99+cvs20050813-1_powerpc.deb
fc4bc6af7a890f73b6d143e06af6ae86 34722 text optional ijsgimpprint_4.3.99+cvs20050813-1_powerpc.deb
7ffc70ea03bbf4b0c1238d4e494087cd 55654 text optional ijsgutenprint_4.3.99+cvs20050813-1_powerpc.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFC/8iKVcFcaSW/uEgRAmTKAKDHxulWbNlrAUlM/Mekx/wg429njwCeMSS3
NjMrtpdsU3Oga6U1hEKMrMk=
=hKOM
-----END PGP SIGNATURE-----
Reply to: