Bug#321599: [patch] saved settings garbled with Auto orientation and PPI scaling
tags 321599 + upstream
thanks
Robert,
The following patch was submitted to the Debian BTS to fix a problem
with the print dialogue in libgutenprintui2. It is surely also
equally applicable to libgutenprintui[1], so I've added that to the
patch.
The rationale for the change, and instructions for reproducing the
problem are available in the original bug report, which may be found
here:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=321599
It looks good, but since libgutenprintui is somewhat hairy, I thought
it could use some double-checking before I commit it.
Regards,
Roger
Index: src/gutenprintui/panel.c
===================================================================
RCS file: /cvsroot/gimp-print/print/src/gutenprintui/panel.c,v
retrieving revision 1.3
diff -u -r1.3 panel.c
--- src/gutenprintui/panel.c 30 Jun 2005 01:42:56 -0000 1.3
+++ src/gutenprintui/panel.c 14 Aug 2005 09:12:09 -0000
@@ -2606,6 +2606,12 @@
gint
stpui_compute_orientation(void)
{
+ /* if this is called before preview_update() -- which happens on startup --
+ * then printable image area is not yet set */
+ stp_get_imageable_area(pv->v, &left, &right, &bottom, &top);
+ printable_width = right - left;
+ printable_height = bottom - top;
+
if (auto_paper_size ||
(printable_width >= printable_height &&
image_true_width >= image_true_height) ||
Index: src/gutenprintui2/panel.c
===================================================================
RCS file: /cvsroot/gimp-print/print/src/gutenprintui2/panel.c,v
retrieving revision 1.4
diff -u -r1.4 panel.c
--- src/gutenprintui2/panel.c 30 Jun 2005 01:42:56 -0000 1.4
+++ src/gutenprintui2/panel.c 14 Aug 2005 09:12:13 -0000
@@ -2630,6 +2630,12 @@
gint
stpui_compute_orientation(void)
{
+ /* if this is called before preview_update() -- which happens on startup --
+ * then printable image area is not yet set */
+ stp_get_imageable_area(pv->v, &left, &right, &bottom, &top);
+ printable_width = right - left;
+ printable_height = bottom - top;
+
if (auto_paper_size ||
(printable_width >= printable_height &&
image_true_width >= image_true_height) ||
--
Roger Leigh
Printing on GNU/Linux? http://gimp-print.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
Reply to: